Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate permissioned signer #15622

Open
wants to merge 1 commit into
base: 10-09-create_benchmark
Choose a base branch
from

Conversation

runtian-zhou
Copy link
Contributor

@runtian-zhou runtian-zhou commented Dec 17, 2024

Description

Adds support for permissioned signer functionality in the Aptos framework by introducing a new feature flag PERMISSIONED_SIGNER. This change enables controlled access to signer capabilities through permission checks. The implementation includes feature flag assertions in the permissioned signer module to ensure the feature is enabled before use.

How Has This Been Tested?

The feature flag implementation follows established patterns used for other feature flags in the system. Testing is enforced through the existing feature flag testing infrastructure.

Key Areas to Review

  • Feature flag integration in permissioned_signer.move
  • New permission checks added to signer_from_permissioned_handle and signer_from_storable_permissioned_handle
  • Feature flag constant definition and helper functions in features.move

Type of Change

  • New feature
  • Aptos Framework

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine
  • Aptos Framework

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 17, 2024

⏱️ 35m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩
general-lints 58s 🟩🟩
semgrep/ci 57s 🟩🟩
file_change_determinator 32s 🟩🟩
permission-check 10s 🟩🟩
permission-check 6s 🟩🟩
check-branch-prefix 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

@runtian-zhou runtian-zhou marked this pull request as ready for review December 17, 2024 15:20
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch from 60ce91a to b99540a Compare December 18, 2024 07:37
@runtian-zhou runtian-zhou force-pushed the 12-17-feature_gate_permissioned_signer branch from 6494f73 to 2bd4613 Compare December 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant