-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(java): add empty versions if pom.xml
dependency versions can't be detected
#7520
feat(java): add empty versions if pom.xml
dependency versions can't be detected
#7520
Conversation
return true | ||
} | ||
if a.Version.String() == "" { | ||
emptyVersionWarn() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to show warnings with group id and artifact id. Can it be overwhelming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to show the warning once to avoid spam in logs
do you think we should still show all dependencies without the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One warning without dependency details and other debug logs with group id and artifact id may be a good compromise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 9424f13
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
Description
See #7446
example:
Related issues
Checklist