Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't use cache for setup-go #7622

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 1, 2024

Description

Time to restore Go dependencies from cache not much less than downloading dependencies (e.g. for linux unit test 32sec vs 29sec).
Therefore, we disable the cache for setup-go to avoid removing test-images and test-vm-images from GH cache.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Oct 1, 2024
@DmitriyLewen DmitriyLewen changed the title ci: save cache of setup-go only for main branch ci: doesn't use cache for setup-go Oct 1, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 1, 2024 07:11
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner October 1, 2024 07:11
@DmitriyLewen DmitriyLewen changed the title ci: doesn't use cache for setup-go ci: don't use cache for setup-go Oct 1, 2024
@knqyf263 knqyf263 enabled auto-merge October 1, 2024 07:17
@knqyf263 knqyf263 added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@DmitriyLewen DmitriyLewen added this pull request to the merge queue Oct 1, 2024
Merged via the queue into aquasecurity:main with commit 7602d14 Oct 1, 2024
15 checks passed
@DmitriyLewen DmitriyLewen deleted the ci/save-go-setup-cache-only-for-main-branch branch October 1, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants