feat(ui): support scaling of resources in UI (#15505) #20097

ratulbasak · 2024-09-25T08:08:22Z

Checklist:

bunnyshell · 2024-09-25T08:08:27Z

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

🔵 /bns:start to start the environment
🚀 /bns:deploy to redeploy the environment
❌ /bns:delete to remove the environment

bunnyshell · 2024-09-25T08:08:28Z

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

🚀 /bns:deploy to deploy the environment

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

* Add state to pkce flow Signed-off-by: Jungho Son <js3692@users.noreply.github.com> * Call unset Signed-off-by: Jungho Son <js3692@users.noreply.github.com> --------- Signed-off-by: Jungho Son <js3692@users.noreply.github.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

* docs: add link to example repo creds yaml Signed-off-by: Nicholas Morey <nicholas@morey.tech> * docs: add project to repo creds examples Signed-off-by: Nicholas Morey <nicholas@morey.tech> --------- Signed-off-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Without the extra line break, the paragraph was rendered as part of the Kustomize application manifest. Signed-off-by: Allan M. de Azevedo <4llan@users.noreply.github.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…18441) * feat: option to disable writing k8s events optioned to write logs for k8s events. Each is passed as an environment variable and defaults to true, disabling it requires explicitly setting the option to false. Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> * feat: option to disable writing k8s events fix unit test - application_test - applicationset_test - project_test - appcontroller_tes - audit_logger_test Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> * rebase Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> --------- Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…goproj#18025) (argoproj#20009) Signed-off-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…roj#20059) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.66.2 to 1.67.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.66.2...v1.67.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…oproj#20065) Signed-off-by: nueavv <nuguni@kakao.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

* fix broken link Signed-off-by: nitishfy <justnitish06@gmail.com> * fix broken link Signed-off-by: nitishfy <justnitish06@gmail.com> --------- Signed-off-by: nitishfy <justnitish06@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…roj#20068) Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

… plugin-based applications (argoproj#19209) * chore: transmit manifest-generate-path resources to the cmp-server for plugin-based applications Signed-off-by: Javier Solana <javier.solana@cabify.com> * use SecureJoin Signed-off-by: Javier Solana <javier.solana@cabify.com> * make cmp manifests generation using manifest generate path annotation configurable by environment variable Signed-off-by: Javier Solana <javier.solana@cabify.com> * fix missing doc running codegen-local Signed-off-by: Javier Solana <javier.solana@cabify.com> * set reposerver.plugin.enable.manifests.generation.using.annotations false by default Signed-off-by: Javier Solana <javier.solana@cabify.com> * define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly Signed-off-by: Javier Solana <javier.solana@cabify.com> * define ARGOCD_REPO_SERVER_PLUGIN_ENABLE_GENERATE_MANIFESTS_USING_MANIFEST_GENERATE_PATHS_ANNOTATION properly Signed-off-by: Javier Solana <javier.solana@cabify.com> * Fix conflict Signed-off-by: Javier Solana <javier.solana@cabify.com> * autogenerate install manifests Signed-off-by: Javier Solana <javier.solana@cabify.com> * add note about common root path calculation for manifest paths annotation Signed-off-by: Javier Solana <javier.solana@cabify.com> * log common root path calculated Signed-off-by: Javier Solana <javier.solana@cabify.com> * app path must be the lower common path Signed-off-by: Javier Solana <javier.solana@cabify.com> * tweaks Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Javier Solana <javier.solana@cabify.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…pgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087) Signed-off-by: Cheng Fang <cfang@redhat.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

codecov · 2024-09-25T09:46:39Z

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@d761c94). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
cmd/argocd/commands/admin/settings.go	33.33%	11 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #20097   +/-   ##
=========================================
  Coverage          ?   55.15%           
=========================================
  Files             ?      324           
  Lines             ?    55221           
  Branches          ?        0           
=========================================
  Hits              ?    30457           
  Misses            ?    22153           
  Partials          ?     2611

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jsoref · 2024-09-25T15:19:56Z

resource_customizations/apps/DaemonSet/actions/discovery.lua

@@ -1,3 +1,4 @@
 local actions = {}
 actions["restart"] = {}
+actions["scale"] = {["defaultValue"] = tostring(obj.spec.replicas), ["hasParameters"] = true,  ["errorMessage"] = "Enter any valid number", ["regexp"]= "^[0-9][0-9]*$"}


Is + not supported?

I'd expect a space before =.

Is \d defined to more than [0-9]?

Added space and Updated regex

jsoref · 2024-09-25T15:20:21Z

resource_customizations/apps/DaemonSet/actions/scale/action.lua

+local os = require("os")
+
+obj.spec.replicas = tonumber(scale)
+return obj


Please add newline at end of file

Added new line

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…rgo-cd into 15505-scale-resources-in-ui

mubarak-j · 2024-09-26T01:57:39Z

resource_customizations/apps/Deployment/actions/discovery.lua

@@ -7,4 +7,5 @@ if obj.spec.paused ~= nil then
    actions["pause"] = {paused}
 end
 actions["resume"] = {["disabled"] = not(paused)}
+actions["scale"] = {["defaultValue"] = tostring(obj.spec.replicas), ["hasParameters"] = true, ["errorMessage"] = "Enter any valid number", ["regexp"] = "^[0-9]*$", }


Can this feature also extended to Argo Rollouts resources which is based on K8s Deployment? Can this be done in this PR?

Probably worth documenting this feature and set expectations when using HPA or application auto-sync is enabled.

This feature in argo rollouts will be done in a separate PR

…le-resources-in-ui

ratulbasak · 2024-09-27T18:16:06Z

Hello @crenshaw-dev, please look into this PR - an enhancement feature: #15505 which was already approved about a year ago. Could you please help me on how to move forward?

reggie-k · 2024-10-15T14:39:29Z

resource_customizations/apps/DaemonSet/actions/discovery.lua

@@ -1,3 +1,4 @@
 local actions = {}
 actions["restart"] = {}
+actions["scale"] = {["defaultValue"] = tostring(obj.spec.replicas), ["hasParameters"] = true, ["errorMessage"] = "Enter any valid number", ["regexp"] = "^[0-9]*$"}


Looks like the scale action is not relevant for Daemon Sets, since they operate on NodeSelectors.

removed DaemonSet scale action

reggie-k · 2024-10-15T15:03:08Z

util/lua/lua.go

@@ -60,7 +61,7 @@ type VM struct {
 	UseOpenLibs bool
 }

-func (vm VM) runLua(obj *unstructured.Unstructured, script string) (*lua.LState, error) {
+func (vm VM) runLua(obj *unstructured.Unstructured, script string, resourceActionParameters []*applicationpkg.ResourceActionParameters) (*lua.LState, error) {


Can a new method, something like runLuaWithResourceActionParameters, be added? And the new method would invoke the existing one and then operate on the input parameters afterwards?
This way most places in the code, that don't require the parameters, can remain unchanged and then only the new code which needs the params would invoke the new function.

thank you for the suggestion, added a new method that invokes the existing one.

reggie-k · 2024-10-15T15:11:41Z

cmd/argocd/commands/admin/settings.go

@@ -600,7 +600,7 @@ argocd admin settings resource-overrides action run /tmp/deploy.yaml restart --a
 				action, err := luaVM.GetResourceAction(&res, action)
 				errors.CheckError(err)

-				modifiedRes, err := luaVM.ExecuteResourceAction(&res, action.ActionLua)
+				modifiedRes, err := luaVM.ExecuteResourceAction(&res, action.ActionLua, nil)


The resource parameters should be passed here, if received from the command line.
An e2e argocd cli test would ensure the cli works correctly with the new functionality.

could you please help on the following error in end-to-end test? seems to be a lock on the Git repository, preventing the application from being created successfully.
time="2024-10-20T21:54:36Z" level=error msg="`../../dist/argocd app create test-installation-id --repo file:///tmp/argo-e2e/testdata.git --dest-server https://kubernetes.default.svc --path guestbook --project default --dest-namespace argocd-e2e--test-installation-id-yrgcy --plaintext --server 127.0.0.1:8088 --auth-token *** --insecure` failed exit status 20: time=\"2024-10-20T21:54:35Z\" level=fatal msg=\"rpc error: code = InvalidArgument desc = application spec for test-installation-id is invalid: InvalidSpecError: Unable to generate manifests in guestbook: rpc error: code = Unknown desc = failed to initialize repository resources: rpc error: code = Internal desc = Failed to fetch default: `git fetch origin --tags --force --prune` failed exit status 1: error: cannot lock ref 'refs/remotes/origin/master': Unable to create '<path to cached source>/.git/refs/remotes/origin/master.lock': File exists.\\n\\nAnother git process seems to be running in this repository

the issue has been resolved, please check

reggie-k · 2024-10-15T15:27:01Z

resource_customizations/apps/Deployment/actions/scale/action.lua

@@ -0,0 +1,4 @@
+local os = require("os")


In ArgoCD, there are automatic tests that run for each built-in resource action.
Those tests are run in TestLuaResourceActionsScript in util/lua/custom_actions_test.go
Those tests expect an input manifest, and and output manifest, that represents the output of the action when run on the input manifest.
Look at resource_customizations/apps/Deployment/actions/action_test.yaml , it has an example of input and output files for the action test, you would need to add a similar for Deployment + StatefulSet. The idea is that you provide a Deployment manifest with replicas set to x as an input, and provide a Deployment manifest with replicas set to y as an output. The automatic test will succeed if your custom action yields the output manifest.
You don't have to do this twice for scale-in and scale-out, one example of a scale change is enough for Deployment and one for StatefulSet.

I have added scale actions in resource_customizations/apps/Deployment/actions/action_test.yaml and resource_customizations/apps/StatefulSet/actions/action_test.yaml files and also tests in util/lua/custom_actions_test.go

Hi @reggie-k, could you please take a look into this? it's green I believe.

reggie-k · 2024-10-15T17:15:09Z

pkg/apis/application/v1alpha1/types.go

-	IconClass   string                `json:"iconClass,omitempty" protobuf:"bytes,4,opt,name=iconClass"`
-	DisplayName string                `json:"displayName,omitempty" protobuf:"bytes,5,opt,name=displayName"`
+	Name          string                `json:"name,omitempty" protobuf:"bytes,1,opt,name=name"`
+	Params        []ResourceActionParam `json:"params,omitempty" protobuf:"bytes,2,rep,name=params"`


Actually, there is an existing Params field, and looking at ResourceActionParam, it has most of the needed fields, I checked and it is used in the util/lua/lua_test.go, and there is even a test there for an action scale. Can you maybe make use of this field and check what this existing scale test is used for?

…le-resources-in-ui

… updated admin cli Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

… for testing Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…le-resources-in-ui

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…le-resources-in-ui

jsoref · 2024-10-24T23:24:01Z

docs/user-guide/scale_application_resources.md

@@ -0,0 +1,21 @@
+# Scale Resources in ArgoCD UI
+
+This enables users to scale resources directly from the ArgoCD UI. Users will be able to increase or decrease the number of replicas (Pods) for Jobs, Deployments, and StatefulSets by using input field. The feature aims to enhance user experience, especially for non-technical users, by eliminating the need to modify configuration files or use kubectl commands for scaling.


Suggested change

This enables users to scale resources directly from the ArgoCD UI. Users will be able to increase or decrease the number of replicas (Pods) for Jobs, Deployments, and StatefulSets by using input field. The feature aims to enhance user experience, especially for non-technical users, by eliminating the need to modify configuration files or use kubectl commands for scaling.

This enables users to scale resources directly from the ArgoCD UI. Users will be able to increase or decrease the number of replicas (Pods) for Jobs, Deployments, and StatefulSets by using an input field. The feature aims to enhance user experience, especially for non-technical users, by eliminating the need to modify configuration files or use kubectl commands for scaling.

jsoref · 2024-10-24T23:24:18Z

docs/user-guide/scale_application_resources.md

+
+
+## Example Usage
+1. User navigates to a Deployment, StatefulSet or Job in any ArgoCD application.


Suggested change

1. User navigates to a Deployment, StatefulSet or Job in any ArgoCD application.

1. User navigates to a Deployment, StatefulSet, or Job in any ArgoCD application.

jsoref · 2024-10-24T23:27:42Z

ui/src/app/applications/components/utils.tsx

+                        <div>
+                            {!action.hasParameters && (
+                                <div className='argo-form-row'>
+                                    <div> Are you sure you want to execute {action.name} action?</div>


I'm not a huge fan of execute in user facing content.

Suggested change

<div> Are you sure you want to execute {action.name} action?</div>

<div> Are you sure you want to perform {action.name} action?</div>

jsoref · 2024-10-24T23:28:20Z

ui/src/app/applications/components/utils.tsx

+            iconClassName: action.iconClass,
+            action: async () => {
+                const confirmed = false;
+                const title = action.hasParameters ? `Enter input parameters for action: ${action.name}` : `Execute ${action.name} action?`;


Suggested change

const title = action.hasParameters ? `Enter input parameters for action: ${action.name}` : `Execute ${action.name} action?`;

const title = action.hasParameters ? `Enter input parameters for action: ${action.name}` : `Perform ${action.name} action?`;

(Alternatively Run)

jsoref · 2024-10-24T23:29:13Z

resource_customizations/apps/StatefulSet/actions/action_test.yaml

+  inputPath: testdata/statefulset.yaml
+  expectedOutputPath: testdata/statefulset-scaled.yaml
+  parameters:
+    scale: "6"


Suggested change

scale: "6"

scale: "6"

(Don't trigger missing newline at eof)

I see no newline at eof

jsoref · 2024-10-24T23:29:52Z

resource_customizations/apps/Deployment/actions/testdata/deployment-scaled.yaml

+  readyReplicas: 2
+  replicas: 3
+  unavailableReplicas: 1
+  updatedReplicas: 3


Suggested change

updatedReplicas: 3

updatedReplicas: 3

Don't add missing newline at eof

I see no newline at eof

jsoref · 2024-10-24T23:30:17Z

resource_customizations/apps/Deployment/actions/action_test.yaml

+  expectedOutputPath: testdata/deployment-scaled.yaml
+  parameters:
+    scale: "6"


Suggested change

scale: "6"

scale: "6"

Don't add missing newline at eof

I see no newline at eof

Right, that's effectively a warning. Don't do that. Add a newline.

Thank you! should I add this as a comment in the top?

No, just add an extra newline at the end of each file

…le-resources-in-ui

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…le-resources-in-ui

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

…le-resources-in-ui

andrii-korotkov-verkada · 2024-11-09T04:33:06Z

Note: you have to include #15505 in the PR description as well to link to the issue properly.

ratulbasak · 2024-11-09T13:47:54Z

Note: you have to include #15505 in the PR description as well to link to the issue properly.

added

ratulbasak requested a review from a team as a code owner September 25, 2024 08:08

ratulbasak and others added 16 commits September 25, 2024 10:49

15505 added scale feature

4782eaa

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

docs: fix paragraph in "User Guide/Kustomize" (argoproj#20053)

fba32af

Without the extra line break, the paragraph was rendered as part of the Kustomize application manifest. Signed-off-by: Allan M. de Azevedo <4llan@users.noreply.github.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

ci: Allow forks to opt-in for codeql (argoproj#19996)

5ab655b

Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

feat(ui): move graphs by dragging mouse in app resource tree view (ar…

1bcaeec

…goproj#18025) (argoproj#20009) Signed-off-by: linghaoSu <linghao.su@daocloud.io> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

fix: corrected --roleARN to --role-arn as per updated CLI option (arg…

92ba40d

…oproj#20065) Signed-off-by: nueavv <nuguni@kakao.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

fix: fix broken link (argoproj#20070)

c6a5bac

* fix broken link Signed-off-by: nitishfy <justnitish06@gmail.com> * fix broken link Signed-off-by: nitishfy <justnitish06@gmail.com> --------- Signed-off-by: nitishfy <justnitish06@gmail.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

chore(deps): bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0 (argop…

d17f845

…roj#20068) Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

[Bot] docs: Update Snyk reports (argoproj#20052)

2731116

Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

15505 removed console log

c8c448f

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

15505 updated scale regex starting from 0

b941ef0

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

fix: CVE-2024-45296 Backtracking regular expressions cause ReDoS by u…

f864d68

…pgrading path-to-regexp from 1.8.0 to 1.9.0 (argoproj#20087) Signed-off-by: Cheng Fang <cfang@redhat.com> Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

ratulbasak force-pushed the 15505-scale-resources-in-ui branch from a6efc06 to f864d68 Compare September 25, 2024 08:50

ratulbasak requested review from a team as code owners September 25, 2024 08:50

Merge branch 'master' into 15505-scale-resources-in-ui

4bcaf25

jsoref reviewed Sep 25, 2024

View reviewed changes

ratulbasak added 2 commits September 25, 2024 17:55

Ratul Basak ratulbasak93@gmail.com Updated Lua scripts

0fe0602

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Merge branch '15505-scale-resources-in-ui' of github.com:ratulbasak/a…

d4934f5

…rgo-cd into 15505-scale-resources-in-ui

mubarak-j reviewed Sep 26, 2024

View reviewed changes

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

5628529

…le-resources-in-ui

crenshaw-dev changed the title ~~chore: 15505 support scaling of resources in UI~~ feat(ui): support scaling of resources in UI (#15505) Oct 11, 2024

reggie-k reviewed Oct 15, 2024

View reviewed changes

ratulbasak added 16 commits October 19, 2024 21:32

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

197e4de

…le-resources-in-ui

Ratul Basak ratulbasak93@gmail.com removed Daemonset scale action and…

4b3814b

… updated admin cli Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

9def506

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

2103d9d

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

058a998

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

c2f32b2

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

790e2eb

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

2fae205

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated actions_test and updated c…

f29368c

…li_test Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com commented resourceActionParameters…

e4d0e9f

… for testing Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

236cd5e

…le-resources-in-ui

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

d796515

…le-resources-in-ui

Ratul Basak ratulbasak93@gmail.com updated admin settings

7c983f9

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated custom actions test

8e3cba2

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Ratul Basak ratulbasak93@gmail.com updated custom actions test

0c5cde5

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

59ec974

…le-resources-in-ui

jsoref reviewed Oct 24, 2024

View reviewed changes

ratulbasak added 5 commits October 25, 2024 13:18

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

4942eab

…le-resources-in-ui

Ratul Basak ratulbasak93@gmail.com fixed scale doc and client message

f0cc339

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

8a63326

…le-resources-in-ui

Ratul Basak ratulbasak93@gmail.com Added newline in action_test

9955871

Signed-off-by: ratulbasak <ratulbasak93@gmail.com>

Merge branch 'master' of github.com:ratulbasak/argo-cd into 15505-sca…

f734bb5

…le-resources-in-ui

		@@ -0,0 +1,21 @@
		# Scale Resources in ArgoCD UI

		This enables users to scale resources directly from the ArgoCD UI. Users will be able to increase or decrease the number of replicas (Pods) for Jobs, Deployments, and StatefulSets by using input field. The feature aims to enhance user experience, especially for non-technical users, by eliminating the need to modify configuration files or use kubectl commands for scaling.



		## Example Usage
		1. User navigates to a Deployment, StatefulSet or Job in any ArgoCD application.

	<div> Are you sure you want to execute {action.name} action?</div>
	<div> Are you sure you want to perform {action.name} action?</div>

	const title = action.hasParameters ? `Enter input parameters for action: ${action.name}` : `Execute ${action.name} action?`;
	const title = action.hasParameters ? `Enter input parameters for action: ${action.name}` : `Perform ${action.name} action?`;

feat(ui): support scaling of resources in UI (#15505) #20097

Are you sure you want to change the base?

feat(ui): support scaling of resources in UI (#15505) #20097

Conversation

ratulbasak commented Sep 25, 2024 • edited Loading

bunnyshell bot commented Sep 25, 2024 • edited Loading

🔴 Preview Environment stopped on Bunnyshell

bunnyshell bot commented Sep 25, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ratulbasak commented Sep 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ratulbasak Oct 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reggie-k Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrii-korotkov-verkada commented Nov 9, 2024

ratulbasak commented Nov 9, 2024

ratulbasak commented Sep 25, 2024 •

edited

Loading

bunnyshell bot commented Sep 25, 2024 •

edited

Loading

codecov bot commented Sep 25, 2024 •

edited

Loading

ratulbasak Oct 20, 2024 •

edited

Loading

reggie-k Oct 15, 2024 •

edited

Loading