fix: Allow to pass Kubernetes configuration overrides

[raphink]

This allows to override the Kubernetes configuration used to set up the
Port Forward.

Signed-off-by: Raphaël Pinson raphael.pinson@camptocamp.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[raphink]

Not sure why the caching step is failing 🤔

[jannfis]

Not sure why the caching step is failing

Seems like a hiccup with GitHub actions to me. I'll re-run the CI.

[codecov]

Codecov Report

Merging #5906 (f6e9b91) into master (8bfe41b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5906      +/-   ##
==========================================
- Coverage   40.89%   40.88%   -0.01%     
==========================================
  Files         147      147              
  Lines       19633    19634       +1     
==========================================
  Hits         8028     8028              
- Misses      10500    10501       +1     
  Partials     1105     1105              

Impacted Files	Coverage Δ
cmd/argocd-util/commands/app.go	31.57% <0.00%> (-0.14%)	⬇️
cmd/argocd-util/commands/cluster.go	0.00% <0.00%> (ø)
util/kube/portforwarder.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfe41b...f6e9b91. Read the comment docs.

[sbose78]

Could you please help me with an example @raphink ?

[raphink]

@sbose78 certainly. In https://github.com/hashicorp/terraform-provider-kubernetes/blob/main/kubernetes/provider.go for example, the code instantiates a clientcmd.ConfigOverrides{} and passes various fields to it based on the Terraform provider parameters. Then they pass the overrides to the client.

The idea is to do the same for the ArgoCD provider, by allowing to pass Kubernetes parameters to the provider and pass them in the overrides.

This way, users of the provider (and potentially other users of the API client) will be able to specify a cluster and its credentials dynamically.

In the context of Terraform, this is useful as we might create the Kubernetes cluster with Terraform, and then pass the generated cluster parameters dynamically to ArgoCD in the same run.

This is what we do in our DevOps Stack project, where the argocd-helm module takes a kubeconfig parameter as a string, passed by another module creating the cluster (e.g. for EKS: https://github.com/camptocamp/devops-stack/blob/master/modules/eks/aws/main.tf#L108).

At the moment, we need to use a hack to dump the Kube config in a temporary file. Use the ArgoCD Terraform provider would save us from this hack, but we need a way to dynamically pass the cluster credentials to it, in the same Terraform run. Hence this PR.

[raphink]

Any news on this? Is there any change I need to make?

[alexmt]

Thanks for providing the link to the workaround that you are using. So the PR allows using Kubernetes overrides by argocd CLI when port forwarding is used.

LGTM. thank you!