-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade Go module to v2 #5931
Conversation
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
Codecov Report
@@ Coverage Diff @@
## master #5931 +/- ##
=======================================
Coverage 40.91% 40.91%
=======================================
Files 147 147
Lines 19635 19635
=======================================
Hits 8033 8033
Misses 10497 10497
Partials 1105 1105
Continue to review full report at Codecov.
|
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Interesting, I wasn't aware of this. |
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@@ -43,6 +43,9 @@ APIMACHINERY_PKGS=( | |||
k8s.io/api/core/v1 | |||
) | |||
|
|||
export GO111MODULE=on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borrowed that hack from argo workflows https://github.com/argoproj/argo-workflows/blob/4e450e250168e6b4d51a126b784e90b11a0162bc/Makefile#L323
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . Thank you @jannfis
Thanks for collaboration @alexmt |
* chore: Upgrade Go module to v2 Signed-off-by: jannfis <jann@mistrust.net> * Restore import order Signed-off-by: jannfis <jann@mistrust.net> * fix knowntypes_normalizer codegen error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix codegen Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix Procfile Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* 4f9c500 (upstream/master) docs: k8s version in Ingress Configuration documentation (argoproj#5727) * 7c88ac8 feat: Allow to pass Kubernetes configuration overrides (argoproj#5906) * 834a5fa chore: Change grammar in high_availability.md (argoproj#5964) * 2a2b81f fix: Improvements to mobile UI (argoproj#5965) * f06fc0d feat: allow per-version kustomize options (argoproj#5967) * 92c7ca0 chore: make argocd gitpod friendly (argoproj#5973) * 1bc3348 Upgrade gitops-engine (argoproj#5972) * a686f12 fix: run dex as nonroot (argoproj#5815) * ed5c5b6 chore: Update go-git to v5 (argoproj#5520) * ac3d4cc fix: correct package name in Makefile (argoproj#5960) * 24b2cac chore: fix incorrect image name in 'publish' CI job (argoproj#5956) * b37eee1 chore: fix invalid IMAGE_NAMESPACE in image 'publish' CI job (argoproj#5953) * dc4eaff chore: Remove specification of user id for the Redis workload (argoproj#5863) * 8eeb9a0 chore: use clusterrolebinding v1 (argoproj#5939) * 7945286 docs: clarify that the certificate must be in PEM format (argoproj#5946) * de522bf chore: migrate argocd dev images to ghcr.io (argoproj#5948) * 0a53fb1 chore(deps): bump y18n from 4.0.0 to 4.0.1 in /ui (argoproj#5919) * ae49b45 chore: Upgrade Go module to v2 (argoproj#5931) * a2ebe15 add user (argoproj#5938) * 7f5a23d Update USERS.md (argoproj#5835) * 24218b4 docs: Propose an enhancement proposal process (argoproj#5771)
* chore: Upgrade Go module to v2 Signed-off-by: jannfis <jann@mistrust.net> * Restore import order Signed-off-by: jannfis <jann@mistrust.net> * fix knowntypes_normalizer codegen error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix codegen Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix Procfile Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* chore: Upgrade Go module to v2 Signed-off-by: jannfis <jann@mistrust.net> * Restore import order Signed-off-by: jannfis <jann@mistrust.net> * fix knowntypes_normalizer codegen error Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix codegen Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix Procfile Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Fixes #5930
This is one of the recommended approaches given in https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
Context (https://github.com/golang/go/wiki/Modules#semantic-import-versioning):
Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: