Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user #5938

Merged
merged 2 commits into from
Apr 1, 2021
Merged

add user #5938

merged 2 commits into from
Apr 1, 2021

Conversation

yuta-ron
Copy link
Contributor

@yuta-ron yuta-ron commented Apr 1, 2021

Our team is currently using ArgoCD in production.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

yutaroon and others added 2 commits April 1, 2021 10:29
Signed-off-by: yuta-ron <jan.joqr@gmail.com>
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #5938 (6948c68) into master (2faa08e) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5938      +/-   ##
==========================================
+ Coverage   40.88%   40.91%   +0.02%     
==========================================
  Files         147      147              
  Lines       19619    19635      +16     
==========================================
+ Hits         8021     8033      +12     
- Misses      10493    10497       +4     
  Partials     1105     1105              
Impacted Files Coverage Δ
util/helm/helm.go 61.11% <0.00%> (-4.41%) ⬇️
controller/state.go 69.15% <0.00%> (-0.18%) ⬇️
reposerver/repository/repository.go 62.80% <0.00%> (+0.34%) ⬆️
util/helm/client.go 45.02% <0.00%> (+0.38%) ⬆️
util/argo/argo.go 60.75% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2faa08e...6948c68. Read the comment docs.

Copy link
Contributor

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that! Thank you.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit a2ebe15 into argoproj:master Apr 1, 2021
yujunz added a commit to abcue/argo-cd that referenced this pull request Apr 7, 2021
* 4f9c500 (upstream/master) docs: k8s version in Ingress Configuration documentation (argoproj#5727)
* 7c88ac8 feat: Allow to pass Kubernetes configuration overrides (argoproj#5906)
* 834a5fa chore: Change grammar in high_availability.md (argoproj#5964)
* 2a2b81f fix: Improvements to mobile UI (argoproj#5965)
* f06fc0d feat: allow per-version kustomize options (argoproj#5967)
* 92c7ca0 chore: make argocd gitpod friendly (argoproj#5973)
* 1bc3348 Upgrade gitops-engine (argoproj#5972)
* a686f12 fix: run dex as nonroot (argoproj#5815)
* ed5c5b6 chore: Update go-git to v5 (argoproj#5520)
* ac3d4cc fix: correct package name in Makefile (argoproj#5960)
* 24b2cac chore: fix incorrect image name in 'publish' CI job (argoproj#5956)
* b37eee1 chore: fix invalid IMAGE_NAMESPACE in image 'publish' CI job (argoproj#5953)
* dc4eaff chore: Remove specification of user id for the Redis workload (argoproj#5863)
* 8eeb9a0 chore: use clusterrolebinding v1 (argoproj#5939)
* 7945286 docs: clarify that the certificate must be in PEM format (argoproj#5946)
* de522bf chore: migrate argocd dev images to ghcr.io (argoproj#5948)
* 0a53fb1 chore(deps): bump y18n from 4.0.0 to 4.0.1 in /ui (argoproj#5919)
* ae49b45 chore: Upgrade Go module to v2 (argoproj#5931)
* a2ebe15 add user (argoproj#5938)
* 7f5a23d Update USERS.md (argoproj#5835)
* 24218b4 docs: Propose an enhancement proposal process (argoproj#5771)
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
* add user

Signed-off-by: yuta-ron <jan.joqr@gmail.com>
kshamajain99 pushed a commit to kshamajain99/argo-cd that referenced this pull request Apr 16, 2021
* add user

Signed-off-by: yuta-ron <jan.joqr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants