Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

["BUG"] repeat Schedule #172

Closed
nomisRev opened this issue Jun 8, 2020 · 0 comments · Fixed by #184
Closed

["BUG"] repeat Schedule #172

nomisRev opened this issue Jun 8, 2020 · 0 comments · Fixed by #184
Labels
bug Something isn't working
Milestone
0.11.0

Comments

@nomisRev
Copy link
Member

nomisRev commented Jun 8, 2020

What version are you currently using?

0.10.5

What would you like to see?

repeat Schedule behaves incorrectly. See: https://kotlinlang.slack.com/archives/C5UPMM0A0/p1591017049041700

See Arrow Fx Coroutines Schedule implementation for fix.
@nomisRev nomisRev added the bug Something isn't working label Jun 8, 2020
@nomisRev nomisRev added this to the 0.11.0 milestone Jun 8, 2020
@aballano aballano mentioned this issue Jun 11, 2020
Merged
@aballano aballano linked a pull request Jun 11, 2020 that will close this issue
Fixes to Schedule #184
Merged
aballano added a commit that referenced this issue Jun 16, 2020
@aballano @rachelcarmena
Fixes to Schedule (#184)
60a438d 
* Fix schedule recurs #173 returning the number of total iterations, instead of repetitions
* Fix never #174 that should never repeat and basically hang the program
* Fix repeat not waiting for delay after first emission #172
* Also removed Alternative and MonoidK instances as it might not have sense to provide Schedule.never() as MonoidK.empty()

Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Fixes to Schedule arrow-kt/arrow-fx
1 participant
@nomisRev