This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
Fixes to Schedule #184
Merged
Fixes to Schedule #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of MonadError in certain functions
…ad instead of MonadError in certain functions" This reverts commit 385df67.
This was
linked to
issues
Jun 11, 2020
Closed
Closed
Closed
|
Hood benchmark comparison:
|
nomisRev
approved these changes
Jun 15, 2020
| @@ -708,10 +714,13 @@ sealed class Schedule<F, Input, Output> : ScheduleOf<F, Input, Output> { | |||
|
|
|||
| /** | |||
| * Create a schedule that never retries. | |||
There was a problem hiding this comment.
We should make clear here that it'll never return from retry or repeat until canceled.
This is useful in similar situations as never where you need to explicitly suspend until canceled or interrupted. You could compose it at the end of a Schedule using andThen to suspend after a Schedule finishes.
There was a problem hiding this comment.
added a note "Note that this will hang a program if used as a repeat/retry schedule unless cancelled."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedule#172