Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

["BUG"] Schedule.never #174

Closed
nomisRev opened this issue Jun 8, 2020 · 2 comments · Fixed by #184
Closed

["BUG"] Schedule.never #174

nomisRev opened this issue Jun 8, 2020 · 2 comments · Fixed by #184
Assignees
@aballano
Labels
bug Something isn't working
Milestone
0.11.0

Comments

@nomisRev
Copy link
Member

nomisRev commented Jun 8, 2020

What version are you currently using?

0.10.5

What would you like to see?

Schedule.never should wait forever like all other F never operators.

Fixed Arrow Fx Coroutines source

Broken Arrow Fx source
@nomisRev nomisRev added the bug Something isn't working label Jun 8, 2020
@nomisRev nomisRev added this to the 0.11.0 milestone Jun 8, 2020
@aballano
Copy link
Member

@nomisRev the problem here with never is that in the Coroutines impl you're able to pass a never like invoke(suspend { arrow.fx.coroutines.never<Unit>() }) but AFAIK we cannot do that right now with Monad but rather Async, no?

@nomisRev
Copy link
Member Author

nomisRev commented Jun 10, 2020 •
edited
Loading

We have a constraint of MonadDefer for jitterred IIRC. We should do the same here for never.

@aballano aballano self-assigned this Jun 10, 2020
aballano added a commit that referenced this issue Jun 11, 2020
@aballano
Fix schedule recurs #173 and never #174
2546609
@aballano aballano mentioned this issue Jun 11, 2020
Merged
@aballano aballano linked a pull request Jun 11, 2020 that will close this issue
Fixes to Schedule #184
Merged
aballano added a commit that referenced this issue Jun 16, 2020
@aballano @rachelcarmena
Fixes to Schedule (#184)
60a438d 
* Fix schedule recurs #173 returning the number of total iterations, instead of repetitions
* Fix never #174 that should never repeat and basically hang the program
* Fix repeat not waiting for delay after first emission #172
* Also removed Alternative and MonoidK instances as it might not have sense to provide Schedule.never() as MonoidK.empty()

Co-authored-by: Rachel M. Carmena <rachelcarmena@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aballano aballano

Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Fixes to Schedule arrow-kt/arrow-fx
2 participants
@aballano @nomisRev