Show prices on default view of artist auction results. #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context has changed.
…way down to renderPricing so prices can be rendered on first load of app with no user logged in.
artsy-peril
bot
added
the
Version: Patch
…e we just need to know whether pagination occurred, not how many times it occurred.
jpotts244
reviewed
May 21, 2020
zephraph
added
Version: Minor
jpotts244
reviewed
May 21, 2020
jpotts244
reviewed
May 21, 2020
jpotts244
approved these changes
May 21, 2020
…naming it to 'filtersAtDefault' because that's really what it's about. Also moving it up a level in the component tree so it doesn't get evaluated 10 times at each render.
|
Amazing work @artsyjian. Thanks for the detailed comments and test updates as well. 👏 |
|
🚀 PR was released in |
damassi
added a commit
to damassi/force
that referenced
this pull request
May 22, 2020
damassi
added a commit
to artsy/force
that referenced
this pull request
May 22, 2020
…to retire-reaction * 'retire-reaction' of https://github.com/damassi/force: (23 commits) Disable codecov for jest for now [Migration] Comment out experiment viewed [Migration] Fix tracking event invocation Move artsy/reaction#3590 [Migration] Update coffeescript /v2 paths to relative Move artsy/reaction#3587 Move artsy/reaction#3589 Move artsy/reaction#3576 Move artsy/reaction#3572 Rename .babelrc to babel.config.js [Migration] Finish migration [Migration] Migrate tests [Migration] Rename v2/*.test to .jest [Migration] Delete publishing folder [Migration] Update import paths [Migration] Enable incremental type-checking [Migration] Temporarily disable @types for relay [Migration] Storybooks [Migration] Add relay Fix type-check errors in force ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/PURCHASE-1925
Currently on Artist Auction Results, user must be logged-in to see prices. This change is to relax that restriction but only for the default view which is the view on page 1 when filters are at default. We will show prices in the default view even when no user is logged-in.
Please note, due to filter context being incorrect about the page# of the page being viewed (it always says 1), I cannot track the page# the user is on. I resort to tracking whether pagination has occurred. If pagination has occurred, prices are hidden. So if user clicks page 1 while on page 1, the page hasn't changed, but pagination has occurred, prices will be hidden again.
--
Screenshots showing effects of the change:
Not logged-in. Page 1. Default filters. Price shown.
Not logged-in. Page 1. Medium
Paintingchecked. Prices hidden.Not logged-in. Page 2. Default filters. Prices hidden.
