Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increases tap area for tabs #3587

Closed
wants to merge 2 commits into from

Conversation

dzucconi
Copy link
Member

Not a huge patch here just changes the vertical whitespace surrounding the tab to also be hit area

Just opening it up as draft and will merge this into force once @damassi merges the reaction migration.

@artsy-peril artsy-peril bot added the Version: Minor Indicates that this PR should have a minor deploy, usually for new features label May 21, 2020
@damassi
Copy link
Member

damassi commented May 21, 2020

Thnx @dzucconi 👍

@dzucconi
Copy link
Member Author

@damassi 968911a sneaks in a lil fix for the header height on mobile. I know u mentioned you're moving these PRs over. Happy to do so after reaction is merged into force of course — just ping me and lemme know.

@damassi
Copy link
Member

damassi commented May 22, 2020

Oh yeah any fixes are appreciated 👍 I'm trying to get CI green now (everything is all good locally?) so will report back once thats all done.

damassi added a commit to damassi/force that referenced this pull request May 22, 2020
damassi added a commit to artsy/force that referenced this pull request May 22, 2020
…to retire-reaction

* 'retire-reaction' of https://github.com/damassi/force: (23 commits)
  Disable codecov for jest for now
  [Migration] Comment out experiment viewed
  [Migration] Fix tracking event invocation
  Move artsy/reaction#3590
  [Migration] Update coffeescript /v2 paths to relative
  Move artsy/reaction#3587
  Move artsy/reaction#3589
  Move artsy/reaction#3576
  Move artsy/reaction#3572
  Rename .babelrc to babel.config.js
  [Migration] Finish migration
  [Migration] Migrate tests
  [Migration] Rename v2/*.test to .jest
  [Migration] Delete publishing folder
  [Migration] Update import paths
  [Migration] Enable incremental type-checking
  [Migration] Temporarily disable @types for relay
  [Migration] Storybooks
  [Migration] Add relay
  Fix type-check errors in force
  ...
@damassi
Copy link
Member

damassi commented May 23, 2020

This code has been moved to force

@damassi damassi closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version: Minor Indicates that this PR should have a minor deploy, usually for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants