[WIP] Add price sorts to Artist pages' artworks grid #3590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
the
Version: Minor
|
The change on desktop as well is indeed a Good Thing ™️ 😄! This looks good to me-- feel free to merge in when ready. |
damassi
added a commit
to damassi/force
that referenced
this pull request
May 22, 2020
|
Added directly to Force via artsy/force@386a558 |
|
Closing this in favor of the Force commit^ |
damassi
added a commit
to artsy/force
that referenced
this pull request
May 22, 2020
…to retire-reaction * 'retire-reaction' of https://github.com/damassi/force: (23 commits) Disable codecov for jest for now [Migration] Comment out experiment viewed [Migration] Fix tracking event invocation Move artsy/reaction#3590 [Migration] Update coffeescript /v2 paths to relative Move artsy/reaction#3587 Move artsy/reaction#3589 Move artsy/reaction#3576 Move artsy/reaction#3572 Rename .babelrc to babel.config.js [Migration] Finish migration [Migration] Migrate tests [Migration] Rename v2/*.test to .jest [Migration] Delete publishing folder [Migration] Update import paths [Migration] Enable incremental type-checking [Migration] Temporarily disable @types for relay [Migration] Storybooks [Migration] Add relay Fix type-check errors in force ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked WIP due to the Reaction/Force merge in progress cc @damassi
https://artsyproduct.atlassian.net/browse/FX-1956
This adds price sorting options (descending and ascending) to the artist page's artwork grid. Note that while this is ticketed as a mWeb improvement, the artist page is a responsive app, so this actually applies to desktop as well. I assume that's a Good Thing 😄
Mobile
Desktop