Refactor triangle and texture examples to use better practices #356
Conversation
I haven't reviewed any changes yet, but this immediately gives me pause. vulkan-tutorial.com is a bit notorious for teaching poor practice; please don't take its patterns as gospel. |
|
@Ralith I've seen that the build failed on Clippy and Rustfmt but I'll wait until a full review is done before submitting fixes for them? |
|
@hgallagher1993 eh push it |
|
any updates on this? Its been 6 months since the last update? |
| Event::LoopDestroyed => { | ||
| base.device.device_wait_idle().unwrap(); | ||
|
|
||
| for &pipeline in graphics_pipelines.iter() { |
There was a problem hiding this comment.
Probably best practice to drain the Vec here even though it doesn't actually change behavior here that much.
| @@ -559,12 +595,18 @@ impl Drop for ExampleBase { | |||
| .destroy_fence(self.draw_commands_reuse_fence, None); | |||
| self.device | |||
| .destroy_fence(self.setup_commands_reuse_fence, None); | |||
| self.device.free_memory(self.depth_image_memory, None); | |||
| for &framebuffer in self.framebuffers.iter() { | |||
There was a problem hiding this comment.
See earlier comment about draining the vector
Fixes #190
It's a huge commit but almost all of it is just moving around already existing code rather than newly written code. The reason it's so big is because I decided to refactor the ExampleBase so it matches https://vulkan-tutorial.com/ more closely which has the creation of everything broken down into small functions so I decided to do the same with the
ExampleBase:: new(..)so that's pretty much where all the changed lines have come from.As well as that I fixed the order of
destroy_buffer,free_memoryetc so when you close the window it doesn't error saying the device hasn't been destroyed.And I created the
render_triangleandrender_texturefunctions just to keep the event_loop a bit smaller and less convoluted