Update Winit and Fix crash on x11 Linux #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramidzkh
suggested changes
Oct 14, 2021
Because Winit has changed quite a bit since 0.19, some of the test lifecycle had to change. Explanation of the changes: 1) `EventLoop::run` is the new way of starting the event loop. This function will never return. There is `EventLoop::run_return` but that does not exist on macOS, so let's use `EventLoop::run` so all platforms may use the same code. 2) Since the callback winit takes is 'static and I need to process some destructor code, the `ExampleBase::run` function now takes a state object, of type `T`. The state object may be accessed while rendering and when the application is exiting, allowing destruction of Vulkan state. 3) Invocation of the rendering function needs to occur in `RedrawRequested`and we request a redraw always after rendering. 4) Eliminate the `RefCel`l around the event loop by having the event loop outlive the entire application. This means `ExampleBase::new`'s function signature now returns `(EventLoop<()>, Self)` The code appears to run properly after testing.
i509VCB
reviewed
Oct 16, 2021
| event: winit::event::WindowEvent::Destroyed, | ||
| .. | ||
| } => { | ||
| surface_fn.destroy_surface(surface, None); |
There was a problem hiding this comment.
Hydos this is wrong, needs to be moved to the winit::event::Event::LoopDestroyed branch
There was a problem hiding this comment.
Oh wait I can't read. Ignore me
|
Keep in mind that #356 also performs this upgrade, and improves the examples at the same time. |
|
Hmm yeah I think waiting for #356 is better. Doing the update didn't cost me much time anyways. |
|
Ill close this one for now, When is that one getting merged? It looks like it hasn't been touched since 27 feb |
This was
linked to
issues
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
thread 'main' panicked at 'attempted to leave type platform::platform::x11::util::input::PointerState uninitialized, which is invalid', /rustc/c8dfcfe046a7680554bf4eb612bad840e7631c4b/library/core/src/mem/mod.rs:663:9on X11 Linux devices.TODO: