This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Do not run TryParseExact on null dates #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
force-pushed
the
pakrym/fast-date
branch
from
eb83e99 to
a25b911
Compare
pakrym
force-pushed
the
pakrym/fast-date
branch
from
a25b911 to
139976e
Compare
| @@ -241,6 +241,11 @@ internal static string DateToString(DateTimeOffset dateTime) | |||
|
|
|||
| internal static bool TryStringToDate(string input, out DateTimeOffset result) | |||
| { | |||
| if (input == null) | |||
There was a problem hiding this comment.
Does this help to add a check for empty strings or is that not a common occurrence?
There was a problem hiding this comment.
It usually not. This is for the case when header is absent.
|
|
After null short-circuit |
|
🚢 🇮🇹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
@davidfowl @Tratcher