Feat/remove schema parsers #798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: update generic workflows (asyncapi#519) * chore: add next-major-spec prerelease (asyncapi#518) * chore(deps): bump async from 2.6.3 to 2.6.4 (asyncapi#524) Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ajor-spec chore: merge master into next major spec
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
We require all PRs to follow Conventional Commits specification. |
|
SonarCloud Quality Gate failed.
|
|
Removing. Brain was hacked beacuse I used a wrong branch when navigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes an old cleanup task that, for some reason, got lost during some merge/update before releasing v2.
This task is about removing the several schema parsers from this code base as now they all leave back in their own repository. See #482 (comment)
Technically, this could be considered as a BC since we are removing code others could be using. However, we never exposed that, not even in the docs, where we ask people to install from each package. See https://github.com/asyncapi/parser-js#official-supported-custom-schema-parsers.
I would love to release this not as v3.0.0 but just v2.1.0, but I'm open-minded.
Related issue(s)
#482 (comment)