fix: return error if signature len does not eq `65` #717

0x3bfc · 2023-03-06T11:46:04Z

Description

the ecrecover precompile panics if provided signature length is not exactly 65.

engine-precompiles/src/secp256k1.rs

birchmd

While we're looking at ecrecover. It might be good to expand our integration tests for it to cover this case as well. I took a look at geth and extra bytes after a valid signature are simply ignored:

Valid signature:

go-ethereum$ ./build/bin/evm \
    --input 0x18c547e4f7b0f325ad1e56f57e26c745b09a3e503d86e00e5255ff7f715d3d1c000000000000000000000000000000000000000000000000000000000000001c73b1693892219d736caba55bdb67216e485557ea6b6af75f37096c9aa6a5a75feeb940b1d03b21e36b0e47e79769f095fe2ab855bd91e3a38756b7d75a9c4549 \
    --receiver 0x0000000000000000000000000000000000000001 \
    run
0x000000000000000000000000a94f5374fce5edbc8e2a8697c15331677e6ebf0b

Extra bytes:

go-ethereum$ ./build/bin/evm \
    --input 0x18c547e4f7b0f325ad1e56f57e26c745b09a3e503d86e00e5255ff7f715d3d1c000000000000000000000000000000000000000000000000000000000000001c73b1693892219d736caba55bdb67216e485557ea6b6af75f37096c9aa6a5a75feeb940b1d03b21e36b0e47e79769f095fe2ab855bd91e3a38756b7d75a9c4549aabbccddeeff \
    --receiver 0x0000000000000000000000000000000000000001 \
    run
0x000000000000000000000000a94f5374fce5edbc8e2a8697c15331677e6ebf0b

I think our implementation does this properly too, but's good to include a test for it just in case.

engine-precompiles/src/secp256k1.rs

joshuajbouw

As @birchmd noted above, this shouldn't be added until there is test. Unit test is fine enough.

0x3bfc · 2023-03-09T10:31:09Z

As @birchmd noted above, this shouldn't be added until there is test. Unit test is fine enough.

Unit test won't work as it will lead to a compile time error.

joshuajbouw · 2023-03-10T14:38:51Z

As @birchmd noted above, this shouldn't be added until there is test. Unit test is fine enough.

Unit test won't work as it will lead to a compile time error.

Why so?

Aurora-ClickUp · 2023-03-15T10:03:10Z

Task linked: CU-861mfek4f AUR-23 Precompile panics on signatures of invalid length

Aurora-ClickUp · 2023-03-15T10:03:44Z

Task linked: CU-85zrqmcza AUR-23 secp256k1::ecrecover() Precompile Panics on Signatures of Invalid Length

engine-precompiles/src/secp256k1.rs

Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>

* fix: return error if signature len does not eq `65` * fix: avoid magic numbers * fix: tests * fix: return error on size check in compile time * chore: remove outdated code * chore: update tests * fix: update test outputs * Update engine-precompiles/src/secp256k1.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>

@birchmd

## [2.9.0] 2023-04-05 ### Added - Enabled XCC for mainnet release by [@birchmd]. ([#694]) - Added `set_owner` contract method which sets the owner of the contract by [@hskang9]. ([#690]) - New variant of submit function `submit_with_args` which accepts additional arguments along with the transaction such as the max gas price a user is ready to pay by [@aleksuss]. ([#696]) - Added the ability to create and fund XCC sub-accounts from external NEAR accounts by [@birchmd]. ([#735]) ### Changes - Replaced `rjson` with `serde_json` by [@aleksuss]. ([#677]) - Changed owner intended contract methods to now require owner or the contract itself by [@hskang9]. ([#676]) ### Fixes - Fixed nonce incorrectly being incremented on an out of fund failure by [@joshuajbouw]. ([#671]) - Fixed a check in promise results before executing cross contract calls (XCC) callbacks by [@birchmd]. ([#693]) - Fixed a reachable panic in `receive_erc20_tokens` by [@0x3bfc]. ([#709]) - Fixed a lack of minimum size checks when instantiating a new `EthGas` object by [@lempire123]. ([#722]) - Fixed a lack of division by 0 checks in `EthGas::Div()` by [@lempire123]. ([#718]) - Fixed the validation of the return of `exports:storage_remove` by [@0x3bfc]. ([#712]) - Fixed missing account validations of NEAR account IDs by [@0x3bfc]. ([#703]) - Fixed a reachable panic in the `exitToNear` and `exitToEthereum` precompiles if the input amount is greater than 1^128 when cast from a `U256` to `u128` by [@0x3bfc]. ([#681]) - Fixed a reachable panic in `modExp` due to arithmetic overflow by [@0x3bfc]. ([#688]) - Fixed the ability attaching values to Aurora specific precompiles, this no longer is possible, by [@0x3bfc]. ([#714]) - Fixed a return error if an ecrecover signature length is not exactly 65 by [@0x3bfc]. ([#717]) - Fixed size checks on input array passed to `exitToNear` and `exitToEthereum` precompiles by [@0x3bfc]. ([#684]) - Fixed missing gas costs in `exitToNear` and `exitToEthereum` precompiles by [@lempire123]. ([#687]) - Fixed a reachable panic due to out of memory in the `modExp` precompile by [@0x3bfc]. ([#689]) - Fixed an assurance that the `sender_id` has a balance greater than the amount in `ft_transfer_call` by [@0x3bfc]. ([#708]) - Fixed returning `0x` when a length cannot be cast as `usize` instead of returning an error in the `modExp` precompile by [@birchmd]. ([#737]) - Miscellaneous minor fixes by [@0x3bfc]. ([#738]) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Leandro Casuso Montero <leandro.montero@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Alexey Lapitsky <lex@realisticgroup.com> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Alexey Lapitsky <alexey.lapitsky@aurora.dev> Co-authored-by: Hyungsuk Kang <hskang9@gmail.com> Co-authored-by: Ahmed Ali <ahmedaabdulwahed@gmail.com> Co-authored-by: lempire123 <61431140+lempire123@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: return error if signature len does not eq 65

73c1164

0x3bfc requested a review from joshuajbouw as a code owner March 6, 2023 11:46

0x3bfc requested review from aleksuss, birchmd and mrLSD March 6, 2023 11:46

aleksuss reviewed Mar 6, 2023

View reviewed changes

engine-precompiles/src/secp256k1.rs Outdated Show resolved Hide resolved

fix: avoid magic numbers

66dd959

aleksuss reviewed Mar 6, 2023

View reviewed changes

engine-precompiles/src/secp256k1.rs Outdated Show resolved Hide resolved

fix: tests

4c4aca7

birchmd reviewed Mar 7, 2023

View reviewed changes

engine-precompiles/src/secp256k1.rs Outdated Show resolved Hide resolved

fix: return error on size check in compile time

e03783d

birchmd reviewed Mar 8, 2023

View reviewed changes

engine-precompiles/src/secp256k1.rs Outdated Show resolved Hide resolved

chore: remove outdated code

59a7b60

joshuajbouw suggested changes Mar 9, 2023

View reviewed changes

Merge branch 'develop' into fix/0x3bfc/audit-aur-23

6da4a84

Merge branch 'develop' into fix/0x3bfc/audit-aur-23

c64f32b

0x3bfc requested a review from vimpunk as a code owner March 13, 2023 08:15

Merge branch 'develop' into fix/0x3bfc/audit-aur-23

c507962

chore: update tests

801ef73

0x3bfc requested a review from hskang9 as a code owner March 16, 2023 11:36

0x3bfc requested a review from joshuajbouw March 16, 2023 11:36

fix: update test outputs

94e6f89

aleksuss reviewed Mar 16, 2023

View reviewed changes

engine-precompiles/src/secp256k1.rs Outdated Show resolved Hide resolved

Update engine-precompiles/src/secp256k1.rs

471e21d

Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>

aleksuss approved these changes Mar 16, 2023

View reviewed changes

birchmd approved these changes Mar 16, 2023

View reviewed changes

mrLSD approved these changes Mar 17, 2023

View reviewed changes

joshuajbouw approved these changes Mar 21, 2023

View reviewed changes

joshuajbouw added this pull request to the merge queue Mar 21, 2023

joshuajbouw merged commit 30868f9 into develop Mar 21, 2023

joshuajbouw deleted the fix/0x3bfc/audit-aur-23 branch March 21, 2023 11:58

birchmd mentioned this pull request Mar 22, 2023

fix: reachable panic due to out-of-memory in modexp precompile #689

Merged

joshuajbouw mentioned this pull request Apr 5, 2023

Release v2.9.0. #739

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: return error if signature len does not eq `65` #717

fix: return error if signature len does not eq `65` #717

0x3bfc commented Mar 6, 2023

birchmd left a comment

joshuajbouw left a comment

0x3bfc commented Mar 9, 2023 •

edited

Loading

joshuajbouw commented Mar 10, 2023

Aurora-ClickUp commented Mar 15, 2023

Aurora-ClickUp commented Mar 15, 2023

fix: return error if signature len does not eq 65 #717

fix: return error if signature len does not eq 65 #717

Conversation

0x3bfc commented Mar 6, 2023

Description

birchmd left a comment

Choose a reason for hiding this comment

joshuajbouw left a comment

Choose a reason for hiding this comment

0x3bfc commented Mar 9, 2023 • edited Loading

joshuajbouw commented Mar 10, 2023

Aurora-ClickUp commented Mar 15, 2023

Aurora-ClickUp commented Mar 15, 2023

fix: return error if signature len does not eq `65` #717

fix: return error if signature len does not eq `65` #717

0x3bfc commented Mar 9, 2023 •

edited

Loading