-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(modexp): do not return an error when length cannot be cast to usize #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-bug
Category: Something isn't working.
A-precompiles
Area: Issues that relate to the precompiles.
labels
Mar 30, 2023
0x3bfc
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aleksuss
approved these changes
Mar 31, 2023
joshuajbouw
approved these changes
Mar 31, 2023
Merged
birchmd
added a commit
that referenced
this pull request
Apr 5, 2023
joshuajbouw
added a commit
that referenced
this pull request
Apr 5, 2023
## [2.9.0] 2023-04-05 ### Added - Enabled XCC for mainnet release by [@birchmd]. ([#694]) - Added `set_owner` contract method which sets the owner of the contract by [@hskang9]. ([#690]) - New variant of submit function `submit_with_args` which accepts additional arguments along with the transaction such as the max gas price a user is ready to pay by [@aleksuss]. ([#696]) - Added the ability to create and fund XCC sub-accounts from external NEAR accounts by [@birchmd]. ([#735]) ### Changes - Replaced `rjson` with `serde_json` by [@aleksuss]. ([#677]) - Changed owner intended contract methods to now require owner or the contract itself by [@hskang9]. ([#676]) ### Fixes - Fixed nonce incorrectly being incremented on an out of fund failure by [@joshuajbouw]. ([#671]) - Fixed a check in promise results before executing cross contract calls (XCC) callbacks by [@birchmd]. ([#693]) - Fixed a reachable panic in `receive_erc20_tokens` by [@0x3bfc]. ([#709]) - Fixed a lack of minimum size checks when instantiating a new `EthGas` object by [@lempire123]. ([#722]) - Fixed a lack of division by 0 checks in `EthGas::Div()` by [@lempire123]. ([#718]) - Fixed the validation of the return of `exports:storage_remove` by [@0x3bfc]. ([#712]) - Fixed missing account validations of NEAR account IDs by [@0x3bfc]. ([#703]) - Fixed a reachable panic in the `exitToNear` and `exitToEthereum` precompiles if the input amount is greater than 1^128 when cast from a `U256` to `u128` by [@0x3bfc]. ([#681]) - Fixed a reachable panic in `modExp` due to arithmetic overflow by [@0x3bfc]. ([#688]) - Fixed the ability attaching values to Aurora specific precompiles, this no longer is possible, by [@0x3bfc]. ([#714]) - Fixed a return error if an ecrecover signature length is not exactly 65 by [@0x3bfc]. ([#717]) - Fixed size checks on input array passed to `exitToNear` and `exitToEthereum` precompiles by [@0x3bfc]. ([#684]) - Fixed missing gas costs in `exitToNear` and `exitToEthereum` precompiles by [@lempire123]. ([#687]) - Fixed a reachable panic due to out of memory in the `modExp` precompile by [@0x3bfc]. ([#689]) - Fixed an assurance that the `sender_id` has a balance greater than the amount in `ft_transfer_call` by [@0x3bfc]. ([#708]) - Fixed returning `0x` when a length cannot be cast as `usize` instead of returning an error in the `modExp` precompile by [@birchmd]. ([#737]) - Miscellaneous minor fixes by [@0x3bfc]. ([#738]) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Leandro Casuso Montero <leandro.montero@aurora.dev> Co-authored-by: Michael Birch <michael.birch@aurora.dev> Co-authored-by: Alexey Lapitsky <lex@realisticgroup.com> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Alexey Lapitsky <alexey.lapitsky@aurora.dev> Co-authored-by: Hyungsuk Kang <hskang9@gmail.com> Co-authored-by: Ahmed Ali <ahmedaabdulwahed@gmail.com> Co-authored-by: lempire123 <61431140+lempire123@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EVM precompiles generally do not return errors; they take whatever input users give and do their best to return a sensible output. For example
We see this input calls
modexp
with the size of both base and modulus both equal to zero, and the size of the exponent equal tou64::MAX
. Since themodexp
precompile output is bounded by the size of the modulus, we know the output is empty because the size of the modulus is zero, even though an exponent of the requested size could not actually exist in most hardware.In our implementation we return an error from the
modexp
precompile if the lengths do not fit in ausize
value, which in the case of Wasm is 32 bits. Therefore our implementation returns an error on the above input instead of retuning the empty value that geth returns. This PR fixes the issue by using a saturating cast intousize
from the given input. This should be fine because non-trivial inputs (i.e. inputs where the modulus is non-zero) will have lengths that fit intousize
no problem, or else the computation will run out of gas.This problem of returning an error for the
usize
cast is actually a little worse than just incompatibility with Ethereum. It also creates an inconsistency with the standalone engine because Wasm has 32-bitusize
while the standalone tends to run on 64-bit platforms. This means that the above input (with exponent length equal tou64::MAX
) returns an error in the Wasm contract, but passed in the standalone engine. After the change in this PR it passes on both compilation targets (as verified by the new integration test case).Testing
Additional test case in
modexp
integration tests.