-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.9.0. #739
Merged
Merged
Release v2.9.0. #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: apply clippy::as_conversions lint to all sub-crates * chore: into -> u128::from
* add set_owner method * fix format * refactor set_owner method with borsh args parameters and adding new transaction kind * remove warnings * add traits for new TransactionKind parameter * add a match fill arm for new TransactionKind parameter * add match arms for BorshTransaction and TransactionKind * replace `as` coversions to `from` conversions * explicitly declare types on number constants * add custom type conversion From trait for handling data loss on `as` type casting * replace `as` to `try_into` * fix typo * lint fix * lint fix * set variant order in BorshTransactionKind and return json encoded bool for the method result * use TryFrom in type conversions * format code * remove as keyword * Panic on same previous owner input * Update engine-standalone-storage/src/relayer_db/types.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * Update engine-standalone-storage/src/relayer_db/types.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * add tests for setting owner in standalone environment * format codes * update Error type on TransactionDuration TryFromIntError is for integral integers; including unsigned ones. * Optimize set_owner tests and place them in sanity.rs * Refactor set_owner standalone tests use `test_utils` function * fix lint * fix input on test_set_owner_fail_on_same_owner * add error type on standalone tests * lint fix * remove unused dependancy * remove wrong comments * add set_owner method to standalone env * format codes * remove unneeded output in set_owner * refactor json args parse in set_owner * modify tests * remove outdated comment * refactor standalone test with json input * format codes * refactor standalone input method handler with json input * use borsh for now * merge all converted types into one struct type * remove unused comment * remove unnecessary output in set_owner --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
* fix:Include private checking method first on admin method It turns out every private function changed into admin has failing point where it conflicts with admin checking method. * add comments for admin method checker * fix: set factory_update_address_version as private * remove unused comment
* chore: apply nursery and pedantic clippy lints * chore: apply nursery and pedantic clippy lints #2 * changes proposed by code review * chore: fix build after merge * chore: remove unused constants
* fix: setting the upgrade index prior calling `stage_upgrade` * Update engine/src/lib.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * fix: remove unused state --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
…#722) * Size check * size check * syntax * fixes * fix * fmt * fix
* fix: Lack of Division by `0` Checks In `EthGas::Div()` * fix: enforce div by zero check through type `NonZeroU64`
* fix: avoid attaching values to precompiles * fix: use the correct types * fix: lint errors * fix: more clippy errors * fix: more clippy errors
* fix: return error if signature len does not eq `65` * fix: avoid magic numbers * fix: tests * fix: return error on size check in compile time * chore: remove outdated code * chore: update tests * fix: update test outputs * Update engine-precompiles/src/secp256k1.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
#684) * fix: size checks in input array passed to `exitToNear` & `exitToEthereum` * fix: check for non-deterministic input size * fix: minor refactor Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * chore: fix tests * refactor: input validation with more strict input size * fix: minor fix in ExitToEthereum precompile * fix: clippy error * Update engine-precompiles/src/native.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * fix: minor update `parse_inputs` * fix: clippy lint errors --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
…679) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
…706) Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.5.2...v6.5.3) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.18.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…687) * Update native.rs * Remove spaces * chore: make clippy happy --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> Co-authored-by: Ahmed Ali <ahmedaabdulwahed@gmail.com>
* change evm dependancies to corresponding versions on Cargo.lock * remove unused directory * add state-migration-test to .gitignore * remove cache on unused directories instead of .gitignore change
* chore: trigger `capacity overflow` and `attempt to add with overflow` panics * fix: tests and add extra edge cases tests * fix: clippy error * fix: update checks for out of memory and capacity errors * fix: revert to old gas estimate * fix: minor test refactor * fix: oom but it fails with capacity overflow * fix: add capacity error check * fix: never returns errors from precompiles * chore: clean up and add more tests * chore: more tests * refactor: zero modulus check * fix: remove unncessary check * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * fix: add helper function for test inputs * fix: add integration tests * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * Update engine-precompiles/src/modexp.rs Co-authored-by: Michael Birch <michael.birch@aurora.dev> * fix: `StandardPrecompiles.sol` compilation errors * fix: revert to old implementation of `StandardPrecompiles` * fix: integration tests * refactor: `generate_modexp_test_input` * fix: adding struct for test input --------- Co-authored-by: Michael Birch <michael.birch@aurora.dev>
* fix: ensure `sender_id` has a balance is greater than amount * fix: clippy errors * fix: prevent setting an arbitrary value for `amount` * adding test cases * Update engine-tests/src/tests/eth_connector.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * Update engine-tests/src/tests/eth_connector.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
…accounts (#735) * Feat: allow creating and funding XCC sub-accounts from external NEAR accounts * Add test for using XCC without bridging wNEAR * Add fund_xcc_sub_account support to standalone engine * Avoid panics
* fix: `mint_eth_on_aurora` may panic if fee > amount * fix: gas cost calc with `checked_add` in precompile * fix: replace `unwrap()` with explicit error msg * fix: use `unwrap_or_default()`instead * fix: some typos * fix: more typos * fix: outdated comments * fix: renaming addr to account_id * Update engine-precompiles/src/secp256k1.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * Update engine/src/connector.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> * fix: some issues with error messages and overflows * Update engine-precompiles/src/secp256k1.rs Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev> --------- Co-authored-by: Oleksandr Anyshchenko <oleksandr.anyshchenko@aurora.dev>
birchmd
approved these changes
Apr 5, 2023
aleksuss
reviewed
Apr 5, 2023
joshuajbouw
force-pushed
the
release/2.9.0
branch
from
April 5, 2023 14:54
dbd963c
to
55d243a
Compare
joshuajbouw
force-pushed
the
release/2.9.0
branch
from
April 5, 2023 14:56
55d243a
to
09b0754
Compare
aleksuss
approved these changes
Apr 5, 2023
RomanHodulak
approved these changes
Apr 5, 2023
mrLSD
approved these changes
Apr 5, 2023
0x3bfc
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.9.0] 2023-04-05
Added
set_owner
contract method which sets the owner of the contract by [@hskang9]. ([Add set_owner method for Aurora DAO #690])submit_with_args
which accepts additional arguments along with the transaction such as the max gas price a user is ready to pay by [@aleksuss]. ([feat: add a new submit method with additional arguments #696])Changes
rjson
withserde_json
by [@aleksuss]. ([feat: replace rjson with serde_json #677])Fixes
receive_erc20_tokens
by [@0x3bfc]. ([fix: reachable panic inreceive_erc20_tokens()
#709])EthGas
object by [@lempire123]. ([Fix: Lack of Minimum Size Checks When Instantiating New EthGas Object #722])EthGas::Div()
by [@lempire123]. ([fix: Lack of Division by0
Checks InEthGas::Div()
#718])exports:storage_remove
by [@0x3bfc]. ([fix: handle the return value ofexports::storage_remove()
#712])exitToNear
andexitToEthereum
precompiles if the input amount is greater than 1^128 when cast from aU256
tou128
by [@0x3bfc]. ([fix: return error ifamount
is greater than2^128
#681])modExp
due to arithmetic overflow by [@0x3bfc]. ([fix: reachable panic due to arithmetic overflow #688])65
#717])exitToNear
andexitToEthereum
precompiles by [@0x3bfc]. ([fix: size checks on input array passed toexitToNear
&exitToEther
#684])exitToNear
andexitToEthereum
precompiles by [@lempire123]. ([Fix: Missing Gas Costs in exitToNear and exitToEthereum Precompiles #687])modExp
precompile by [@0x3bfc]. ([fix: reachable panic due to out-of-memory inmodexp
precompile #689])sender_id
has a balance greater than the amount inft_transfer_call
by [@0x3bfc]. ([fix: ensuresender_id
has a balance is greater than amount #708])0x
when a length cannot be cast asusize
instead of returning an error in themodExp
precompile by [@birchmd]. ([Fix(modexp): do not return an error when length cannot be cast to usize #737])