Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix spell-check #4289

Merged
merged 8 commits into from
Jul 26, 2023
Merged

refactor: fix spell-check #4289

merged 8 commits into from
Jul 26, 2023

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jul 14, 2023 •
edited by HansRobo
Loading

Description

Fix spell-check

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Note for package owner

approved status

  • perception_utils
  • tensorrt_common
  • tvm_utility
  • ground_segmentation
  • lidar_centerpoint_tvm
  • map_based_prediction
  • multi_object_tracker
  • occupancy_grid_map_outlier_filter
  • probabilistic_occupancy_grid_map
  • radar_fusion_to_detected_objects
  • radar_object_clustering
  • tensorrt_classifier
  • tensorrt_yolo
  • tensorrt_yolox
  • traffic_light_classifier
  • traffic_light_fine_detector
  • traffic_light_map_based_detector
  • traffic_light_multi_camera_fusion
  • traffic_light_occlusion_predictor
  • traffic_light_ssd_fine_detector

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jul 14, 2023
miursh added 2 commits July 15, 2023 00:30
@miursh
refactor: fix spell-check
395c576 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh
fix spell-check
d323c6e 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 5.00% and project coverage change: -0.44 ⚠️

Comparison is base (8e6c02e) 15.04% compared to head (cacd3e8) 14.61%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4289      +/-   ##
==========================================
- Coverage   15.04%   14.61%   -0.44%     
==========================================
  Files        1508     1569      +61     
  Lines      103765   106388    +2623     
  Branches    31716    31133     -583     
==========================================
- Hits        15613    15546      -67     
- Misses      71125    74014    +2889     
+ Partials    17027    16828     -199
Flag Coverage Δ *Carryforward flag
differential 2.88% <5.00%> (?)
total 15.24% <ø> (+0.20%) ⬆️ Carriedforward from 1d2ca3b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/tensorrt_common/src/tensorrt_common.cpp 0.00% <ø> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <ø> (ø)
...lter/occupancy_grid_map_outlier_filter_nodelet.hpp 0.00% <0.00%> (ø)
.../src/occupancy_grid_map_outlier_filter_nodelet.cpp 0.00% <0.00%> (ø)
...ed_occupancy_grid_map/occupancy_grid_map_fixed.cpp 0.00% <ø> (ø)
...cupancy_grid_map/occupancy_grid_map_projective.cpp 0.00% <ø> (ø)
...ssifier/include/tensorrt_classifier/calibrator.hpp 0.00% <0.00%> (ø)
...on/tensorrt_classifier/src/tensorrt_classifier.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
...nsorrt_yolox/include/tensorrt_yolox/calibrator.hpp 0.00% <0.00%> (ø)
... and 14 more

... and 166 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miursh miursh force-pushed the fix/perception_spell_check branch from 9f3c791 to 146c130 Compare July 14, 2023 15:47
@miursh
fix typo
12273ec 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh force-pushed the fix/perception_spell_check branch from 146c130 to 12273ec Compare July 14, 2023 16:03
@miursh miursh marked this pull request as draft July 14, 2023 16:07
miursh added 3 commits July 18, 2023 22:34
@miursh
Fix obvious typo, shortened words
7c58ff4 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh
Fix obvious typo, shortened words, in common directory
1598d94 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh
add cspell ignore
6789782 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 20, 2023
@miursh miursh marked this pull request as ready for review July 20, 2023 12:24
manato
manato approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding tensorrt_common and tensorrt_yolox , they look good to me.
I really appreciate for your correction 🙇

@wep21 wep21 mentioned this pull request Jul 21, 2023
Merged
7 tasks
@HansRobo HansRobo mentioned this pull request Jul 21, 2023
Closed
scepter914
scepter914 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for radar_fusion_to_detected_objects and radar_object_clustering

ambroise-arm
ambroise-arm approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ambroise-arm ambroise-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tvm_utility

@miursh @yukke42
Update perception/tensorrt_classifier/CMakeLists.txt
1d2ca3b 
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
badai-nguyen
badai-nguyen approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for test_*_ground_filter

@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 24, 2023
tkimura4
tkimura4 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for map_based_prediction

yukkysaito
yukkysaito approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda mentioned this pull request Jul 24, 2023
Closed
7 tasks
angry-crab
angry-crab approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@angry-crab angry-crab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansRobo
Copy link
Member

Based on CODEOWNERS, at least, we have to get approvals from @wep21 and @Mingyu1991 for merging this pull-request.

@wep21 @Mingyu1991
Could you review this pull-request?

wep21
wep21 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 13b96ad into main Jul 26, 2023
@miursh miursh deleted the fix/perception_spell_check branch July 26, 2023 05:36
@HansRobo HansRobo mentioned this pull request Jul 26, 2023
Open
3 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 27, 2023
Merged
PhoebeWu21 pushed a commit to PhoebeWu21/autoware.universe that referenced this pull request Aug 18, 2023
@miursh @yukke42 @PhoebeWu21
refactor: fix spell-check (autowarefoundation#4289)
efa3bf8 
* refactor: fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix typo

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words, in common directory

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* add cspell ignore

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Update perception/tensorrt_classifier/CMakeLists.txt

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: PhoebeWu21 <wwcphoebe@gmail.com>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
@miursh @yukke42 @kyoichi-sugahara
refactor: fix spell-check (autowarefoundation#4289)
94e3684 
* refactor: fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix typo

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words, in common directory

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* add cspell ignore

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Update perception/tensorrt_classifier/CMakeLists.txt

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
@miursh @yukke42 @kosuke55
refactor: fix spell-check (autowarefoundation#4289)
b0ade6c 
* refactor: fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix spell-check

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* fix typo

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Fix obvious typo, shortened words, in common directory

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* add cspell ignore

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Update perception/tensorrt_classifier/CMakeLists.txt

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukke42 yukke42 yukke42 left review comments

@manato manato manato approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@scepter914 scepter914 scepter914 approved these changes

@wep21 wep21 wep21 approved these changes

@ambroise-arm ambroise-arm ambroise-arm approved these changes

@tkimura4 tkimura4 tkimura4 approved these changes

@angry-crab angry-crab angry-crab approved these changes

@badai-nguyen badai-nguyen badai-nguyen approved these changes

@Mingyu1991 Mingyu1991 Awaiting requested review from Mingyu1991

@dan-dnn dan-dnn Awaiting requested review from dan-dnn

@amc-nu amc-nu Awaiting requested review from amc-nu

@YoshiRi YoshiRi Awaiting requested review from YoshiRi

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.