Hotfix/v1.6.1 normalized quaternion vectormap #1019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aohsato
reviewed
Jan 9, 2018
| @@ -1344,6 +1344,7 @@ visualization_msgs::Marker createMarker(const std::string& ns, int id, int type) | |||
| marker.id = id; | |||
| marker.type = type; | |||
| marker.lifetime = ros::Duration(); | |||
| marker.pose.orientation= tf::createQuaternionMsgFromRollPitchYaw(0, 0, 0); | |||
There was a problem hiding this comment.
plz fix with same method
orientation.w = 1.0
aohsato
approved these changes
Jan 9, 2018
|
want one more reviewer |
|
@kitsukawa, pls review this.
2018/01/09 午後7:00 "Yusuke FUJII" <notifications@github.com>:
… want one more reviewer
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1019 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAToCzDev22eQzhDD0oirKjx9A6aucAdks5tIzitgaJpZM4RXiNU>
.
|
|
it now works properly even without this PR due to RVIZ was modified, |
|
The fix should also go into develop. |
|
@dejanpan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
**PRODUCTION **
Description
This PR solves the issue of autowarefoundation/autoware_ai#11 .
The initial value of geometry_msgs::Quaternion is (x, y, z, w = 0, 0, 0, 0),
but RVIZ only accepts normalized quaternions.
Please review the reviewer for any missing corrections.