fix: return theme declaration file from render func #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyonsbp
approved these changes
Jun 6, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 122 122
Lines 5430 5430
Branches 1620 1620
=======================================
Hits 5089 5089
Misses 323 323
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
awinberg-aws
approved these changes
Jun 6, 2023
bombguy
added a commit
that referenced
this pull request
Jun 19, 2023
* fix: parse operand value when field is number type (#1013) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.0 (#1014) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: fix storage field prop import to storagemanager (#1016) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.1 (#1017) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: add getOverrideProps to StorageManager (#1020) * fix: add getOverrideProps to StorageManager * fix: add overrideProps to Field component * Revert "fix: add overrideProps to Field component" This reverts commit 6393718. * chore(release): v2.14.2 (#1022) * fix: return theme declaration file from render func (#1023) Co-authored-by: Doesnt Matter <not@used.com> * fix: alias colliding imported model name in hasMany relationship (#1019) Co-authored-by: Justin Shih <jushih@amazon.com> * chore: update cli check --------- Co-authored-by: Justin Shih <36183898+Jshhhh@users.noreply.github.com> Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: Charles Shin <charlshi@amazon.com> Co-authored-by: David Lopez <letsbelopez@gmail.com> Co-authored-by: Doesnt Matter <not@used.com> Co-authored-by: Roshane Pascual <rotp@amazon.com>
rtpascual
added a commit
that referenced
this pull request
Jun 23, 2023
* fix: parse operand value when field is number type (#1013) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.0 (#1014) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: fix storage field prop import to storagemanager (#1016) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.1 (#1017) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: add getOverrideProps to StorageManager (#1020) * fix: add getOverrideProps to StorageManager * fix: add overrideProps to Field component * Revert "fix: add overrideProps to Field component" This reverts commit 6393718. * chore(release): v2.14.2 (#1022) * fix: return theme declaration file from render func (#1023) Co-authored-by: Doesnt Matter <not@used.com> * fix: alias colliding imported model name in hasMany relationship (#1019) Co-authored-by: Justin Shih <jushih@amazon.com> * chore: update cli check * chore: add specific cypress version to fix 12.15.0 bug (#1028) --------- Co-authored-by: Justin Shih <36183898+Jshhhh@users.noreply.github.com> Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: Charles Shin <charlshi@amazon.com> Co-authored-by: David Lopez <letsbelopez@gmail.com> Co-authored-by: Doesnt Matter <not@used.com>
letsbelopez
added a commit
that referenced
this pull request
Jul 19, 2023
* fix: parse operand value when field is number type (#1013) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.0 (#1014) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: fix storage field prop import to storagemanager (#1016) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.1 (#1017) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: add getOverrideProps to StorageManager (#1020) * fix: add getOverrideProps to StorageManager * fix: add overrideProps to Field component * Revert "fix: add overrideProps to Field component" This reverts commit 6393718. * chore(release): v2.14.2 (#1022) * fix: return theme declaration file from render func (#1023) Co-authored-by: Doesnt Matter <not@used.com> * fix: alias colliding imported model name in hasMany relationship (#1019) Co-authored-by: Justin Shih <jushih@amazon.com> * chore: update cli check --------- Co-authored-by: Justin Shih <36183898+Jshhhh@users.noreply.github.com> Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: Charles Shin <charlshi@amazon.com> Co-authored-by: David Lopez <letsbelopez@gmail.com> Co-authored-by: Doesnt Matter <not@used.com> Co-authored-by: Roshane Pascual <rotp@amazon.com>
letsbelopez
added a commit
that referenced
this pull request
Jul 19, 2023
* feat: add graphql support for components * feat: add graphql support for create form (#1008) * feat: add graphql support for create form with relationships (#1010) * Update GraphQL API import and refactor GraphQL call expressions (#1012) * chore: update graphql api import * chore: refactor graphql call expressions to common function * chore: use pluralize for graphql list queries * feat: add graphql support for update form (#1015) * feat: add graphql support for update form * fix: update snapshot * feat: add more assertions to check for graphql support * fix: removing obselete snapshot * fix: force update mutation to use id var * chore: add declaration snapshots (#1018) * Update from main (#1025) * fix: parse operand value when field is number type (#1013) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.0 (#1014) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: fix storage field prop import to storagemanager (#1016) Co-authored-by: Justin Shih <jushih@amazon.com> * chore(release): v2.14.1 (#1017) Co-authored-by: Justin Shih <jushih@amazon.com> * fix: add getOverrideProps to StorageManager (#1020) * fix: add getOverrideProps to StorageManager * fix: add overrideProps to Field component * Revert "fix: add overrideProps to Field component" This reverts commit 6393718. * chore(release): v2.14.2 (#1022) * fix: return theme declaration file from render func (#1023) Co-authored-by: Doesnt Matter <not@used.com> * fix: alias colliding imported model name in hasMany relationship (#1019) Co-authored-by: Justin Shih <jushih@amazon.com> * chore: update cli check --------- Co-authored-by: Justin Shih <36183898+Jshhhh@users.noreply.github.com> Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: Charles Shin <charlshi@amazon.com> Co-authored-by: David Lopez <letsbelopez@gmail.com> Co-authored-by: Doesnt Matter <not@used.com> Co-authored-by: Roshane Pascual <rotp@amazon.com> * feat: update GraphqlRenderConfig to use separate props for each file path * feat: graphql support for collections (#1027) * feat: graphql support for collections * chore: refactor collection element to helper function and update addMappedImport * feat: adding graphql support for update forms with relationship (#1030) * fix: wrapping list graphql result for await (#1032) * feat: add graphql support for relationship forms with autocomplete field * fix: autocomplete options prop using incorrect records (#1035) * feat: add graphql support for relationship forms with autocomplete field * fix: autocomplete options prop using incorrect records * feat: add helpers to identify api dependencies * fix: use related model name instead of field in generating graphql qu… (#1039) * fix: use related model name instead of field in generating graphql queries * fix: updating invalid schema in integ test * feat: exit early in integ test failure * fix: lowering nyc coverage threshold --------- Co-authored-by: Albert Winberg <winberga@amazon.com> Co-authored-by: Roshane Pascual <rtpascual@users.noreply.github.com> Co-authored-by: Charles Shin <charlshi@amazon.com> Co-authored-by: awinberg-aws <100880084+awinberg-aws@users.noreply.github.com> Co-authored-by: Justin Shih <36183898+Jshhhh@users.noreply.github.com> Co-authored-by: Justin Shih <jushih@amazon.com> Co-authored-by: David Lopez <lopezbnd@amazon.com> Co-authored-by: Roshane Pascual <rotp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We aren't returning the declaration value in theme unlike other renderers
Solution
Returns the declaration value for theme
Additional Notes
Links
Ticket
GitHub issue _____
Other links
Verification
Manual tests
Automated tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.