Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clear old dependency resolutions #10691

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Nov 18, 2022

Description of changes

The dependency resolutions are added to the workspace over the time to unblock the build. However they are not removed after the underlying issues were resolved. This PR removes these resolutions and make sure the build and integ tests pass.

Issue #, if available

Description of how you validated changes

https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/16883/workflows/28ee7459-56b1-459c-8709-b489695af0f6

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review November 19, 2022 00:55
@AllanZhengYP AllanZhengYP requested review from a team as code owners November 19, 2022 00:55
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks for the clean up!

@AllanZhengYP AllanZhengYP merged commit 2320dba into main Nov 22, 2022
@AllanZhengYP AllanZhengYP deleted the clear-dep-resolution branch November 22, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants