Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename endpoint to userPoolEndpoint #12276

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

jimblanc
Copy link
Contributor

Description of changes

Renames the endpoint config field to userPoolEndpoint to support custom Identity Pool endpoints in the future.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review October 12, 2023 17:02
@jimblanc jimblanc requested review from a team as code owners October 12, 2023 17:02
elorzafe
elorzafe previously approved these changes Oct 12, 2023
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thanks @jimblanc 🎖️

Copy link
Member

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimblanc jimblanc merged commit b047cd1 into aws-amplify:next/main Oct 16, 2023
23 of 24 checks passed
cshfang pushed a commit to cshfang/amplify-js that referenced this pull request Oct 16, 2023
cshfang added a commit that referenced this pull request Oct 16, 2023
)

* feat(notifications): Refactor push notification to be functional

* chore: v6 re-enable DataStore tests - batch 1 (#12301)

* chore: Re-enable v2/owner-custom-field-default-v2

* chore: Turn on a bunch of v6 DataStore tests

* fix: Integ test gaps

* fix: Include missed test

* Update integ-all.yml

* chore: Reintroduce v2/public-auth-iam-v2 integ test (#12292)

* feat: Rename `endpoint` to `userPoolEndpoint` (#12276)

* chore: Re-enable v2/owner-custom-field-default-v2 (#12294)

* chore: Re-enable all integ tests (#12310)

* chore(inapp): vend the required input/output types and fix RN (#12304)

* chore: vend input oput types
* chore: add message ui types

* Address feedback

---------

Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Co-authored-by: ManojNB <manojnb@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants