chore(inapp): vend the required input/output types and fix RN #12304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
reviewed
Oct 14, 2023
cshfang
previously approved these changes
Oct 14, 2023
cshfang
previously approved these changes
Oct 14, 2023
AllanZhengYP
previously approved these changes
Oct 14, 2023
Samaritan1011001
dismissed stale reviews from AllanZhengYP and cshfang
via
3bb0d15
jimblanc
approved these changes
Oct 16, 2023
cshfang
approved these changes
Oct 16, 2023
Samaritan1011001
merged commit af08620
into
aws-amplify:next/main
23 of 24 checks passed
cshfang
pushed a commit
to cshfang/amplify-js
that referenced
this pull request
Oct 16, 2023
…plify#12304) * chore: vend input oput types * chore: add message ui types
cshfang
added a commit
that referenced
this pull request
Oct 16, 2023
) * feat(notifications): Refactor push notification to be functional * chore: v6 re-enable DataStore tests - batch 1 (#12301) * chore: Re-enable v2/owner-custom-field-default-v2 * chore: Turn on a bunch of v6 DataStore tests * fix: Integ test gaps * fix: Include missed test * Update integ-all.yml * chore: Reintroduce v2/public-auth-iam-v2 integ test (#12292) * feat: Rename `endpoint` to `userPoolEndpoint` (#12276) * chore: Re-enable v2/owner-custom-field-default-v2 (#12294) * chore: Re-enable all integ tests (#12310) * chore(inapp): vend the required input/output types and fix RN (#12304) * chore: vend input oput types * chore: add message ui types * Address feedback --------- Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com> Co-authored-by: ManojNB <manojnb@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Vends the required input/output types and add the sub packages to files so it can fix RN.
Issue #, if available
Description of how you validated changes
yarn link
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.