feat(notifications): Refactor push notification to be functional #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
reviewed
Oct 16, 2023
packages/rtn-push-notification/src/utils/normalizeNativeMessage.ts
Outdated
Show resolved
Hide resolved
packages/rtn-push-notification/src/apis/addTokenEventListener.ts
Outdated
Show resolved
Hide resolved
packages/rtn-push-notification/src/apis/addTokenEventListener.ts
Outdated
Show resolved
Hide resolved
...cations/src/pushNotifications/providers/pinpoint/utils/getPushNotificationUserAgentString.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/types/pushNotifications.ts
Outdated
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/types/pushNotifications.ts
Outdated
Show resolved
Hide resolved
* chore: Re-enable v2/owner-custom-field-default-v2 * chore: Turn on a bunch of v6 DataStore tests * fix: Integ test gaps * fix: Include missed test * Update integ-all.yml
…plify#12304) * chore: vend input oput types * chore: add message ui types
Samaritan1011001
approved these changes
Oct 16, 2023
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Show resolved
Hide resolved
packages/notifications/src/pushNotifications/providers/pinpoint/apis/identifyUser.native.ts
Show resolved
Hide resolved
AllanZhengYP
approved these changes
Oct 16, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR converts the Push Notification category into functions instead of classes. Also:
@aws-amplify/react-nativefor better module loading pattern and type loadingDescription of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.