Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add advanced option to disable upload cache #13931

Conversation

AllanZhengYP
Copy link
Member

Description of changes

The PR introduces new options to internal uploadData API and implementation to disable the upload caching for StorageBrowser. It does not affect the functionality or interface of the public API. Here's the details:

  • Add a new resumableUploadsCache option to uploadData internal API. By default it's not set, indicating the internal API does NOT cache in-progress multipart uploads.
  • Hoist the cache instance(defaultStorage from core package) to the public client-side uploadData API. And set it to resumableUploadsCache option of internal API. It indicates the client-side public APIs continue to support the upload cache.

Description of how you validated changes

Unit test

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP force-pushed the storage-browser/internals-disablecache-release branch from 6b01479 to 0b58650 Compare October 16, 2024 20:10
@AllanZhengYP AllanZhengYP marked this pull request as ready for review October 16, 2024 21:02
@AllanZhengYP AllanZhengYP changed the title feat(storage): add diable cache advanced option feat(storage): add advanced option to disable upload cache Oct 16, 2024
Copy link
Member

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the good PR & inline docs

@AllanZhengYP AllanZhengYP merged commit 5145064 into aws-amplify:storage-browser/integrity Oct 17, 2024
28 checks passed
@AllanZhengYP AllanZhengYP deleted the storage-browser/internals-disablecache-release branch October 17, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants