Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui-react-storage): clean up outdated styles file #6197

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Nov 22, 2024

Description of changes

Clear the unused storage-browser-styles.css

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: ecf9509

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jordanvn
jordanvn previously approved these changes Nov 22, 2024
Copy link
Member

@jordanvn jordanvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Confirmed that I didn't see any styling regression on build

cshfang
cshfang previously approved these changes Nov 25, 2024
@AllanZhengYP AllanZhengYP dismissed stale reviews from cshfang and jordanvn via 679ce58 January 11, 2025 00:39
@AllanZhengYP AllanZhengYP merged commit 06419a7 into main Jan 27, 2025
34 checks passed
@AllanZhengYP AllanZhengYP deleted the chore/clear-sb-styles branch January 27, 2025 18:33
jjarvisp added a commit that referenced this pull request Jan 28, 2025
* chore(react): remove direct usage of react-test-renderer and types (#6255)

* chore(deps): upgrade next deps to point to ^14.2.15 (#6263)

* fix(docs): use correct listLocation attribute names in Storage Browser auth example (#6264)

* chore(react-native): update allowed peerDep to >=0.70 (#6266)

* chore(react): add support for react 19 (#5826)

* chore(storage-browser): bump up package size limit (#6267)

* chore(changeset): update react 19 changeset from patch to minor bump (#6269)

* chore(react): remove radix-ui upgrades (#6268)

* fix(docs): remove typo from liveness detector core docs (#6256)

* Version Packages (#6261)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: remove temporary pin to react 18 in react@latest build tests (#6274)

* chore: remove temporary use of react 18 in react@latest build tests

* chore: update workflow for forced test run

* chore: adjusting testing strategy, modify publish workflow instead of reusable test

* chore: reverting temporary testing changes

* Revert support for React 19 (#6278)

* Revert "chore: remove temporary pin to react 18 in react@latest build tests (#6274)"

This reverts commit d9ee32d.

* Revert "fix(docs): remove typo from liveness detector core docs (#6256)"

This reverts commit 9d71dd8.

* Revert "chore(react): remove radix-ui upgrades (#6268)"

This reverts commit c623990.

* Revert "chore(changeset): update react 19 changeset from patch to minor bump (#6269)"

This reverts commit 7045aed.

* Revert "chore(storage-browser): bump up package size limit (#6267)"

This reverts commit a79b8e9.

* Revert "chore(react): add support for react 19 (#5826)"

This reverts commit 954e9be.

* chore: add changeset

* Version Packages (#6281)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): bump nextjs version (#6284)

* chore: add v0.76 and latest to React Native build system tests (#6285)

* chore: add react native v0.76 build system tests to CI
* chore: add react native 'latest' to build system tests

* fix(github-actions): bump upload-artifact to v4 (#6289)

* feat(i18n): add Chinese translations for password fields in zh.ts (#6125)

Co-authored-by: Caleb Pollman <cpollman1@gmail.com>

* test(e2e): add storage-browser offline tests (#6206)

* test(e2e): add storage-browser offline tests

* address feedback

* fix EOF

* fix EOF

* Update packages/e2e/cypress/integration/common/shared.ts

Co-authored-by: Caleb Pollman <cpollman@amazon.com>

* address feedback

---------

Co-authored-by: Caleb Pollman <cpollman@amazon.com>

* chore(docs): update react web Authenticator hideSignUp example (#6290)

* feat(react): reenable react 19 support (#6296)

* Revert "Revert support for React 19 (#6278)"

This reverts commit 475e4a3.

* update radix deps
* remove radix namespace sanitization
* migrate/cleanup FileUploader component override example
* add ExtendedView component for surfacing ReactNode conflicts
* Remove extended and overridden react types

* chore(build-system-tests): disable react@latest tests (#6297)

* Version Packages (#6292)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(ci): add retry delays to build tests & upgrade actions/cache (#6291)

* chore: add delay between install retries, swap RN to use install script
* chore: upgrade actions/cache to v4.2.0

* chore(build-system-tests): reenable react@latest tests (#6299)

* fix(slider): remounted controlled value not updating (#6301)

* fix(ui): fix and add missing sv translations (#6288)

Co-authored-by: Jordan Van Ness <jordvn@amazon.com>
Co-authored-by: Caleb Pollman <cpollman1@gmail.com>

* chore(changeset): add changeset for PR #6301 (#6303)

* fix(react-storage): enable default checksum algorithm for create folder action  (#6305)

* fix: include default checksum alg header in createFolder action

* test: update createFolder test spec for checksum alg header

* chore: adding changeset

* Version Packages (#6304)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(docs): Update Android UI component versions (#6311)

* chore(deps-dev): bump vite from 5.2.14 to 5.4.12 (#6307)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.14 to 5.4.12.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.4.12/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.4.12/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(storage-browser): export UseView type (#6314)

* chore(ui-react-storage): clean up outdated styles file (#6197)

Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com>

* chore(react-native): add fed sign in example env (#6318)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Co-authored-by: Tiffany Yeung <tnwyeung@amazon.com>
Co-authored-by: Jordan Van Ness <jordvn@amazon.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: BeforeSunset16 <145817984+BeforeSunset16@users.noreply.github.com>
Co-authored-by: Caleb Pollman <cpollman1@gmail.com>
Co-authored-by: Ashwin Kumar <ashwinkumar2468@gmail.com>
Co-authored-by: Danny Banks <djb@amazon.com>
Co-authored-by: berg-dee <berg_deejay0d@icloud.com>
Co-authored-by: Vincent Tran <freedom1378@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com>
@calebpollman calebpollman mentioned this pull request Jan 28, 2025
jordanvn added a commit that referenced this pull request Jan 28, 2025
@jordanvn jordanvn mentioned this pull request Jan 28, 2025
5 tasks
calebpollman pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants