-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-storage): enable default checksum algorithm for create folder action #6305
Conversation
🦋 Changeset detectedLatest commit: 5a4210c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.../react-storage/src/components/StorageBrowser/actions/handlers/__tests__/createFolder.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for adding this fix in, lgtm !
I guess upload is the only API that supports the checksumAlgorithm
param
3c1a6ed
to
5a4210c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
…er action (#6305) * fix: include default checksum alg header in createFolder action * test: update createFolder test spec for checksum alg header * chore: adding changeset
* chore(react): remove direct usage of react-test-renderer and types (#6255) * chore(deps): upgrade next deps to point to ^14.2.15 (#6263) * fix(docs): use correct listLocation attribute names in Storage Browser auth example (#6264) * chore(react-native): update allowed peerDep to >=0.70 (#6266) * chore(react): add support for react 19 (#5826) * chore(storage-browser): bump up package size limit (#6267) * chore(changeset): update react 19 changeset from patch to minor bump (#6269) * chore(react): remove radix-ui upgrades (#6268) * fix(docs): remove typo from liveness detector core docs (#6256) * Version Packages (#6261) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: remove temporary pin to react 18 in react@latest build tests (#6274) * chore: remove temporary use of react 18 in react@latest build tests * chore: update workflow for forced test run * chore: adjusting testing strategy, modify publish workflow instead of reusable test * chore: reverting temporary testing changes * Revert support for React 19 (#6278) * Revert "chore: remove temporary pin to react 18 in react@latest build tests (#6274)" This reverts commit d9ee32d. * Revert "fix(docs): remove typo from liveness detector core docs (#6256)" This reverts commit 9d71dd8. * Revert "chore(react): remove radix-ui upgrades (#6268)" This reverts commit c623990. * Revert "chore(changeset): update react 19 changeset from patch to minor bump (#6269)" This reverts commit 7045aed. * Revert "chore(storage-browser): bump up package size limit (#6267)" This reverts commit a79b8e9. * Revert "chore(react): add support for react 19 (#5826)" This reverts commit 954e9be. * chore: add changeset * Version Packages (#6281) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): bump nextjs version (#6284) * chore: add v0.76 and latest to React Native build system tests (#6285) * chore: add react native v0.76 build system tests to CI * chore: add react native 'latest' to build system tests * fix(github-actions): bump upload-artifact to v4 (#6289) * feat(i18n): add Chinese translations for password fields in zh.ts (#6125) Co-authored-by: Caleb Pollman <cpollman1@gmail.com> * test(e2e): add storage-browser offline tests (#6206) * test(e2e): add storage-browser offline tests * address feedback * fix EOF * fix EOF * Update packages/e2e/cypress/integration/common/shared.ts Co-authored-by: Caleb Pollman <cpollman@amazon.com> * address feedback --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> * chore(docs): update react web Authenticator hideSignUp example (#6290) * feat(react): reenable react 19 support (#6296) * Revert "Revert support for React 19 (#6278)" This reverts commit 475e4a3. * update radix deps * remove radix namespace sanitization * migrate/cleanup FileUploader component override example * add ExtendedView component for surfacing ReactNode conflicts * Remove extended and overridden react types * chore(build-system-tests): disable react@latest tests (#6297) * Version Packages (#6292) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(ci): add retry delays to build tests & upgrade actions/cache (#6291) * chore: add delay between install retries, swap RN to use install script * chore: upgrade actions/cache to v4.2.0 * chore(build-system-tests): reenable react@latest tests (#6299) * fix(slider): remounted controlled value not updating (#6301) * fix(ui): fix and add missing sv translations (#6288) Co-authored-by: Jordan Van Ness <jordvn@amazon.com> Co-authored-by: Caleb Pollman <cpollman1@gmail.com> * chore(changeset): add changeset for PR #6301 (#6303) * fix(react-storage): enable default checksum algorithm for create folder action (#6305) * fix: include default checksum alg header in createFolder action * test: update createFolder test spec for checksum alg header * chore: adding changeset * Version Packages (#6304) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(docs): Update Android UI component versions (#6311) * chore(deps-dev): bump vite from 5.2.14 to 5.4.12 (#6307) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.14 to 5.4.12. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.12/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.12/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(storage-browser): export UseView type (#6314) * chore(ui-react-storage): clean up outdated styles file (#6197) Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com> * chore(react-native): add fed sign in example env (#6318) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: Tiffany Yeung <tnwyeung@amazon.com> Co-authored-by: Jordan Van Ness <jordvn@amazon.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: BeforeSunset16 <145817984+BeforeSunset16@users.noreply.github.com> Co-authored-by: Caleb Pollman <cpollman1@gmail.com> Co-authored-by: Ashwin Kumar <ashwinkumar2468@gmail.com> Co-authored-by: Danny Banks <djb@amazon.com> Co-authored-by: berg-dee <berg_deejay0d@icloud.com> Co-authored-by: Vincent Tran <freedom1378@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: AllanZhengYP <zheallan@amazon.com> Co-authored-by: ashika112 <155593080+ashika112@users.noreply.github.com>
Description of changes
The purpose of this change is to add the default checksum algorithm header to create folder requests originating from storage browser. This allows the create folder action to be compatible with S3 buckets that have object lock enabled and a default retention set.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.