Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-rds] Supports defining variables for a CfnDBInstance in a DatabaseCluster #9926

Closed
1 of 2 tasks
hixi-hyi opened this issue Aug 24, 2020 · 2 comments · Fixed by #10324
Closed
1 of 2 tasks

[aws-rds] Supports defining variables for a CfnDBInstance in a DatabaseCluster #9926

hixi-hyi opened this issue Aug 24, 2020 · 2 comments · Fixed by #10324
Assignees
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@hixi-hyi
Copy link
Contributor

hixi-hyi commented Aug 24, 2020

Add the following properties in DatabaseCluster.

autoMinorVersionUpgrade: boolean
allowMajorVersionUpgrade: boolean
deleteAutomatedBackups: boolean
enablePerformanceInsights: boolean

The most important one is autoMinorVersionUpgrade.

Use Case

autoMinorVersionUpgrade

When the database instance is automatically upgrade by AWS, drift is detected between cdk(cloudformation) and the actual resource, and the upgrade cannot be performed with cdk.
To work around this and deploy the cloudformation, you need to remove the RDS from the management target and re-include it. cdk does not support this.
We should be able to manage the migration in our own time.

Others (allowMajorVersionUpgrade, deleteAutomatedBackups, enablePerformanceInsights)

I'd like to set these parameters as well.

Proposed Solution

  1. Define the properties below
    export interface InstanceProps {
  2. Pass properties to CfnDBInstance
    const instance = new CfnDBInstance(this, `Instance${instanceIndex}`, {

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@hixi-hyi hixi-hyi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 24, 2020
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Aug 24, 2020
@theo-beers
Copy link

To add to this: we received some mails from AWS where they actually advised to disable autoMinorVersionUpgrade to prevent stack drift.

@skinny85 skinny85 added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2020
@skinny85 skinny85 added this to the [GA] RDS milestone Sep 9, 2020
@hixi-hyi
Copy link
Contributor Author

The enablePerformanceInsights is implemented by #10092

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 14, 2020
@skinny85 skinny85 removed this from the [GA] RDS milestone Sep 22, 2020
@mergify mergify bot closed this as completed in #10324 Sep 24, 2020
mergify bot pushed a commit that referenced this issue Sep 24, 2020
…stances (#10324)

fixes #9926

Added the following parameters to DatabaseCluster.
* AutoMinorVersionUpgrade
* AllowMajorVersionUpgrade
* DeleteAutomatedBackups

#10092 as a reference, only defined simple parameters.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants