feat(rds): performance insights for DatabaseCluster instances #10092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the EnablePerformanceInsights and related props to `InstanceProps` for instances within a cluster. _Note:_ I opted not to try to coalesce `InstanceProps`, `DatabaseInstanceNewProps`, and `DatabaseInstanceSourceProps` in this PR; there are a ton of overlapping properties, but it's not immediately clear which fields are relevant for cluster instances vs standalone instances. I think investigating and validiting how to combine these is a significantly larger task. fixes #7957
njlynch
added
the
pr-linter/exempt-readme
skinny85
approved these changes
Sep 1, 2020
cluster->instance Co-authored-by: Adam Ruka <adamruka@amazon.com>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Sep 12, 2020
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
…stances (#10324) fixes #9926 Added the following parameters to DatabaseCluster. * AutoMinorVersionUpgrade * AllowMajorVersionUpgrade * DeleteAutomatedBackups #10092 as a reference, only defined simple parameters. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the EnablePerformanceInsights and related props to
InstancePropsforinstances within a cluster.
Note: I opted not to try to coalesce
InstanceProps,DatabaseInstanceNewProps, andDatabaseInstanceSourcePropsin this PR; thereare a ton of overlapping properties, but it's not immediately clear which fields
are relevant for cluster instances vs standalone instances. I think
investigating and validiting how to combine these is a significantly larger
task.
fixes #7957
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license