feat(rds): add support for update and backup properties to Cluster instances

[hixi-hyi]

fixes #9926

Added the following parameters to DatabaseCluster.

• AutoMinorVersionUpgrade
• AllowMajorVersionUpgrade
• DeleteAutomatedBackups

#10092 as a reference, only defined simple parameters.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[hixi-hyi]

If this policy is acceptable, I can also add these parameters to DatabaseInstance.

[skinny85]

Thanks a lot for the contribution @hixi-hyi ! Some small comments, and one question.

[skinny85]

is this really true by default? The documentation says:

Constraints: Major version upgrades must be allowed when specifying a value for the EngineVersion parameter that is a different major version than the DB instance's current version.

I guess that suggests that the default is, in fact, false...?

[hixi-hyi]

Surely the default value for AllowMajorVersionUpgrade may be false.
Reading the documentation, this parameter may not be used routinely and is only needed when changing instance types, but I don't understand exactly what it is. (There was no value for AllowMajorVersionUpgrade in the results of aws rds describe-instances)

The @default value is currently written from the Cloudformation documentation.
However, I haven't programmatically set it, and its behavior is dependent on Cloudformation.

Should such a parameter be written as @default None? Or should I explicitly set true or false in the cdk?

I'd like to hear your opinion.

[skinny85]

If not setting it and setting it to false provide the same result (as I believe it does in this case), it should be @default false.

[hixi-hyi]

I understood. Thank you for your reply.
In fact, AllowMajorUpgrade is default false, and it seems to be necessary to add this parameter when upgrading the major version.

Pull request has been modified.

[skinny85]

Hey @hixi-hyi ,

looks like some trailing spaces snuck into the file:

@aws-cdk/aws-rds: /codebuild/output/src654474608/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-rds/lib/props.ts
@aws-cdk/aws-rds:   73:1  error  Trailing spaces not allowed  no-trailing-spaces
@aws-cdk/aws-rds:   80:1  error  Trailing spaces not allowed  no-trailing-spaces

Would you mind updating the PR (and also inclding the change discussed in #10324 (comment) )? Thanks!

[skinny85]

Putting in "Request changes" awaiting @hixi-hyi 's new iteration to remove this from my ToDo list.

Pull request has been modified.

[hixi-hyi]

@skinny85
I forgot to run yarn lint on gitpod, which I did.
I'm very sorry, but I'd like to know if there's anything else that needs to be addressed.

[skinny85]

@skinny85
I forgot to run yarn lint on gitpod, which I did.
I'm very sorry, but I'd like to know if there's anything else that needs to be addressed.

Everything is great @hixi-hyi , thanks so much for your contribution!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 291c222
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[hixi-hyi]

Thanks for the merge and the fix testcode :D

[skinny85]

Thanks for the merge and the fix testcode :D

My pleasure, thanks for the contribution!