feat(aws-iot): topic rules and actions #13581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
remove error action property
hollanddd
commented
Mar 14, 2021
|
|
||
| constructor(scope: Construct, id: string, props: TopicRuleProps) { | ||
| super(scope, id, { | ||
| physicalName: props.ruleName || 'TODO', |
There was a problem hiding this comment.
How to ruleName when it's property is optional
|
|
||
| public bind(rule: iot.ITopicRule): iot.TopicRuleActionConfig { | ||
| // Allow rule to publish to topic | ||
| const role = this.props.role || singletonTopicRuleRole(rule, [new iam.PolicyStatement({ |
There was a problem hiding this comment.
borrowed from aws-event-target and have clear gaps in understanding or the role mechanism in this case.
include `aws-iot-actions`
include as dependency
add integration tests and remove circular dependency caused by ensure. The integrations show that two iam roles are generated. I'm not sure of the best course of action
add `aws-iot-actions` as dependency
and another one
use physical name
handle error action
fix description and add SQL version enum
add updated integrations
…s#13598) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#13624) This [PR](aws#13488) upgraded our Node runtimes from `10` to `14`. The problem is that Node14 isn't supported for lambda functions using inline code (i.e `ZipFile`). Change to Node12 specifically for the notification handler since it's the only one using `InlineLambda`. Fixes aws#13620 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The build script was assuming everything in the package directory was itself a directory; not necessarily true on macOS machines. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I've received feedback from some folks who would like to start contributing to the CDK but found the contribution guide unwieldy. Attempting to wittle down and simplify. Move content around so that useful information is at the top. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The previous attempt at a fix missed one important case: the types
of the values involved in the `{ Fn::Join }` expression didn't actually
match up. They all needed to be strings, but the previous implentation
just dropped list-typed values in there.
Unfortunately, there is no way to do it correctly with just string
manipulation in CloudFormation (`{ Fn::Join }` etc), so we'll have
to resort to using a Custom Resource if we encounter list values.
Actually fixes aws#13465.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is an attempt to make the documentation safer to parse and render. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes aws#13583 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds optional `policyDocument` prop to `TopicPolicyProps` to allow passing existing policy documents. fixes aws#7934 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Allows setting an authorizer and authorization scopes that will be applied to all routes of the api. @nija-at this is the bit we forgot In the first PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
added
p2
review/large
effort/large
|
Thanks for the contribution @hollanddd! We have reviewed this pull request and marking it as p2, which means that we are unable to work on it immediately. We especially value community contributed code, so this is not a final decision. |
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
rix0rrr
added
feature-request
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds construct for IoT Topic Rule and introduces
@aws-iot/aws-iot-actions.The supported Actions are Lambda, SNS, RepublishTopic & SQS.
This is a bit better and needs review when time permits:
TopiRule.grantPublishacceptsITopicRuleand thetopicstring to publish to an MQTT topic. IoT topics are maintained by the system designer and do not contain aCfnTopicconstruct backing.Closes #5420
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license