fix(ec2): naming collisions when using ec2.InitFile.fromAsset() on multiple instances in the same stack

packages/aws-cdk-lib/aws-ec2/lib/cfn-init-elements.ts

@@ -4,6 +4,7 @@ import * as iam from '../../aws-iam';
 import * as s3 from '../../aws-s3';
 import * as s3_assets from '../../aws-s3-assets';
 import { Duration } from '../../core';
+import { md5hash } from '../../core/lib/helpers-internal';
 
 /**
  * An object that represents reasons to restart an InitService
@@ -424,7 +425,7 @@ export abstract class InitFile extends InitElement {
   public static fromAsset(targetFileName: string, path: string, options: InitFileAssetOptions = {}): InitFile {
     return new class extends InitFile {
       protected _doBind(bindOptions: InitBindOptions) {
-        const asset = new s3_assets.Asset(bindOptions.scope, `${targetFileName}Asset`, {
+        const asset = new s3_assets.Asset(bindOptions.scope, `${md5hash(bindOptions.scope.node.children.toString())}${targetFileName}Asset`, {
           path,
           ...options,
         });
@@ -941,7 +942,7 @@ export abstract class InitSource extends InitElement {
   public static fromAsset(targetDirectory: string, path: string, options: InitSourceAssetOptions = {}): InitSource {
     return new class extends InitSource {
       protected _doBind(bindOptions: InitBindOptions) {
-        const asset = new s3_assets.Asset(bindOptions.scope, `${targetDirectory}Asset`, {
+        const asset = new s3_assets.Asset(bindOptions.scope, `${md5hash(bindOptions.scope.node.children.toString())}${targetDirectory}Asset`, {
           path,
           ...bindOptions,
         });

packages/aws-cdk-lib/aws-ec2/test/cfn-init-element.test.ts

@@ -330,6 +330,63 @@ describe('InitFile', () => {
     });
   });
 
+  test('does not have naming collision when multiple EC2 instances are defined in the same stack with using InitFile.fromAsset with the same targetFileName', () => {
+    // GIVEN
+    const myApp = new App();
+    const myStack = new Stack(myApp, 'myStack');
+    const vpc = new ec2.Vpc(myStack, 'vpc');
+
+    // WHEN
+    new ec2.Instance(myStack, 'FirstInstance', {
+      vpc,
+      instanceType:
+        ec2.InstanceType.of(ec2.InstanceClass.T3A, ec2.InstanceSize.MICRO),
+      machineImage: new ec2.AmazonLinuxImage({
+        generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2,
+      }),
+      init: ec2.CloudFormationInit.fromConfigSets({
+        configSets: {
+          default: ['default'],
+        },
+        configs: {
+          default: new ec2.InitConfig([
+            ec2.InitFile.fromAsset(
+              '/target/path/config.json',
+              path.join(__dirname, 'init-configs/configFileForFirstInstance.json'),
+            ),
+          ]),
+        },
+      }),
+    });
+
+    // THEN
+    expect(() => {
+
+      new ec2.Instance(myStack, 'SecondInstance', {
+        vpc,
+        instanceType:
+        ec2.InstanceType.of(ec2.InstanceClass.T3A, ec2.InstanceSize.MICRO),
+        machineImage: new ec2.AmazonLinuxImage({
+          generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2,
+        }),
+        init: ec2.CloudFormationInit.fromConfigSets({
+          configSets: {
+            default: ['default'],
+          },
+          configs: {
+            default: new ec2.InitConfig([
+              ec2.InitFile.fromAsset(
+                '/target/path/config.json',
+                path.join(__dirname, 'init-configs/configFileForSecondInstance.json'),
+              ),
+            ]),
+          },
+        }),
+      });
+
+    }).not.toThrow();
+  });
+
 });
 
 describe('InitGroup', () => {