Skip to content

Conversation

@awood45
Copy link
Contributor

@awood45 awood45 commented Oct 30, 2019

Includes all changes for 0.30.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

awood45 and others added 30 commits September 13, 2019 15:01
This is populating new commands and changes some of the relevant
documentation. This is very much a WIP and not ready to merge.
This actually covers all values we need to prompt for, but is in dire
need of a refactoring, and the GitHub clone logic needs to be
implemented.
The flow works, most edge cases covered. Still have some development
features that need to be pulled out/resolved.
Adds events for Lambda functions for:

1. PreHumanTask
2. AnnotationConsolidation
Handles most cases, still need to clean out some debug logic and write
full test suite.
More tests needed to meet the coverage bar since there's a lot of new
code, but the existing tests work.
With dependency-manager required, cannot have go showing a None type for
that field.
Primarily, refactoring the different primary interactive threads into
different methods.
Windows compatibility check, essentially, and this commit also includes
a Black reformatting.
This enables us to properly test prompts and improves code
coverage. We also managed to entirely remove a code path (location
cannot currently be missing when going to interactive).

Remaining work is to improve unit test coverage of init templates.
It was incorrect to use 'takewhile', as it terminates as soon as there
is a failed check. For Java Maven this caused no templates to be
usable.
Now over the 95% threshold, so `make pr` is passing.
* chore: add some functional tests to appveyor

* print python version

* Change JSONDecodeError to ValueError

* Remove the extra python --version

* fix functional global config tests

* adjust functional tests that run

* don't run manager functional tests

* fix functional tests that are run in appveyor

* Mark invoke and start-lambda integ tests as flaky

This is due to random errors/timeouts happening on windows. The start-api tests already have this flaky annotation but invoke and start-lambda were missed
Response to comments in #1447
Trenton Lipscomb and others added 28 commits October 28, 2019 10:17
Slashes behave differently.
Checking integration test behavior.
Had a bug where the wrong executable name would lead to a premature
exit. This change fixes that.
Will better align with errors in place.
This is a WIP to fix breaking Windows integ tests.
This should have been part of the last commit.
If the shared directory doesn't exist, create it before cloning the
template git repo. This will need to be refactored as some layer code
does the same thing.
Init code assumed existence of shared directory, which is likely but not
guaranteed.
Fixes empty account id in CloudWatch Scheduled Event
Adds SageMaker Ground Truth Lambda events
fix:  Lambda timeout from parameter (#925)
chore: bump version to 0.30.0
* Add HELP_TEXT for init command

* Reformat with Black
@awood45 awood45 merged commit 380183e into master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants