-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: v0.30.0 #1493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chore: v0.30.0 #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is populating new commands and changes some of the relevant documentation. This is very much a WIP and not ready to merge.
This actually covers all values we need to prompt for, but is in dire need of a refactoring, and the GitHub clone logic needs to be implemented.
The flow works, most edge cases covered. Still have some development features that need to be pulled out/resolved.
Adds events for Lambda functions for: 1. PreHumanTask 2. AnnotationConsolidation
Handles most cases, still need to clean out some debug logic and write full test suite.
More tests needed to meet the coverage bar since there's a lot of new code, but the existing tests work.
With dependency-manager required, cannot have go showing a None type for that field.
Primarily, refactoring the different primary interactive threads into different methods.
…o interactive-init
Windows compatibility check, essentially, and this commit also includes a Black reformatting.
This enables us to properly test prompts and improves code coverage. We also managed to entirely remove a code path (location cannot currently be missing when going to interactive). Remaining work is to improve unit test coverage of init templates.
It was incorrect to use 'takewhile', as it terminates as soon as there is a failed check. For Java Maven this caused no templates to be usable.
Now over the 95% threshold, so `make pr` is passing.
* chore: add some functional tests to appveyor * print python version * Change JSONDecodeError to ValueError * Remove the extra python --version * fix functional global config tests * adjust functional tests that run * don't run manager functional tests * fix functional tests that are run in appveyor * Mark invoke and start-lambda integ tests as flaky This is due to random errors/timeouts happening on windows. The start-api tests already have this flaky annotation but invoke and start-lambda were missed
Response to comments in #1447
Slashes behave differently.
Checking integration test behavior.
Had a bug where the wrong executable name would lead to a premature exit. This change fixes that.
Will better align with errors in place.
This is a WIP to fix breaking Windows integ tests.
This should have been part of the last commit.
If the shared directory doesn't exist, create it before cloning the template git repo. This will need to be refactored as some layer code does the same thing.
Init code assumed existence of shared directory, which is likely but not guaranteed.
Interactive Init
Fixes empty account id in CloudWatch Scheduled Event
Adds SageMaker Ground Truth Lambda events
fix: Lambda timeout from parameter (#925)
chore: bump version to 0.30.0
* Add HELP_TEXT for init command * Reformat with Black
jfuss
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all changes for 0.30.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.