Conversation
* exposed extra_context CLI option to pass cookiecutter parameter * bug fix: Remove logic to set extra_context as None * added unit test when extra_context is invalid json * disable lint too-many-statements for do_cli * moved extra_context merging to private method * simplified json merge logic
- `sam package` integration tests
* fix: Move validation of timeout is an int further down the stack * Fix casting floats to ints * pywin32 needs to be under 226 to work with virtualenv module
Split java and ruby builds into two functions, one for in process and one for container. When running java builds on Windows Server 2019, the in process builds where hanging, reason is known. Splitting the tests allows us to run the container builds on Windows Server 2019, which is required due to needing docker that spins up a linux instance. We can then run in-process builds in Visual Studio images, which works for java. This commit will also update the ruby builds on windows but instead of running both in process and container builds, we will only run container builds. When running ruby in-process builds on Visual Studio images, we still see failures (which is assumed to be the same as when they are run on Windows Server 2019 which is an ssl issue). This will at least allow us to verify container builds for ruby, which will give us confidence that things are working as expected.
jfuss
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.