cdk-support-dev branch merged to develop branch by moelasmar · Pull Request #3146 · aws/aws-sam-cli

moelasmar · 2021-08-06T05:45:03Z

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

Add input/output type hints to new functions/methods
Write design document (Do I need to write a design document?)
Write unit tests
Write/update functional tests
Write/update integration tests
make pr passes
make update-reproducible-reqs if dependencies were changed
Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* chore: Use BUILD_TAG instead of JENKINS_URL to identify Jenkins env * Keep JENKINS_URL

* Updated Deprecated compile to implementation * Updated Tabs to Spaces * Updated for Kotlin * Updated More Tabs to Spaces

* Added Auto Create ECR Design Doc * Updated Format * Addressed feedback

When validating the sam template, SAM CLI requires credentials to get the IAM Manged Policies. SAM Translator also requires the region in order to figure out the parition. Previously, SAM Translator assumed this to be on the Env but SAM CLI could get this information from a command line argument or a profile. This commit passes the boto_session into the SAM Translator lib (v1.35.0 or later), so that SAM Translator can figure out the partition from the information passed to SAM CLI. Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>

…am local commands (aws#2806)

Co-authored-by: Xia Zhao <xazhao@amazon.com>

…ws#2821) * [Refactor] extract git-clone functionality out of InitTemplates class to its own class * apply review comments * typo * apply review comments

* chore: add command line options to pyinstaller build script * Update quotes * fix the dist folder name * update logs * trigger appveyor build

Co-authored-by: Slava Senchenko <sencslav@amazon.com>

* add github actions to automate our github issue workflow * reformat * update name format * update response message to be more precise * updated with the correct sam bot login name * updated with the correct token name * updated label name and bot name Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>

* Point numpy version to <1.19 to avoid PEP 317 failure * Update integ test python requirements which contain numpy * Fixing to numpy 1.20.2 * Revert "Fixing to numpy 1.20.2" This reverts commit a03f4d7. * Fixing numpy version to <1.20.3

Issue: aws#2355 Added integration tests for `validate` command Co-authored-by: Slava Senchenko <sencslav@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>

… S3 URL (aws#2785)

* refactor logs command library * re-organize due to click usage * address comments * adding pylint disable for console consumer * make pylint happy with python 3.6 Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>

…#2864) * Enable --app-template argument for Image package-type while generating a new SAM project using 'sam init' * Fix the exception message * normalize pathes in UT to pass on windows * normalize project-template local path

* feat: Allow dir_checksum() to accept a ignore_list * feat: Ignore .aws-sam when calculate cache md5

… intrinsics) (aws#2879) * fix: Fix crash when nested CFN stack has dict TemplateURL

* get questions' default answers from toml * make black happy * add more docs * rename question's attribute 'default_from_toml' to 'defaultFromToml' and rename 'valueof' to 'key' and add some docs * Add preload_value * Allow to pass toml file to interactive flow run() * Update related classes to utilize proload value context object * Update test * Add missing docstring * Remove samconfig change * Rename extra_context to context because it is required field now * Remove toml logics from this PR * Update comment Co-authored-by: Sam Liu <xinhol@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>

* chore: updating version of watchdog. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>

* chore: Update aws_lambda_builders to 1.4.0 * Update integration tests for new maven behavior * Add integ test for PEP 600 tags

aws#2883) * Adds missing unit tests for LayerBuildDefinition in build_graph * fix black formatting

…d assertions (aws#2909)

* samconfig debug level logging fixed; documentation updated * integration tests fix * help text improved Co-authored-by: Slava Senchenko <sencslav@amazon.com>

…ws#2891)" (aws#2918) This reverts commit 2a13a69.

* chore: fix pylint failures in python3.9 * chore: fix pylint failures in python3.9 * chore: bump pylint version to 2.9.0 * fix typo * Add disabling reasons on new rules

… pull limitation (aws#3137)

…rror' (aws#3043) * add sample payload for 'sam local generate-event stepfunctions error' * add better default for error

…pport-dev-merged-to-develop # Conflicts: # appveyor.yml # mypy.ini # samcli/__init__.py # samcli/commands/_utils/template.py # samcli/commands/build/build_context.py # samcli/commands/build/command.py # samcli/commands/deploy/deploy_context.py # samcli/commands/deploy/guided_context.py # samcli/commands/init/__init__.py # samcli/commands/init/init_templates.py # samcli/commands/local/cli_common/invoke_context.py # samcli/commands/local/invoke/cli.py # samcli/commands/local/start_api/cli.py # samcli/commands/local/start_lambda/cli.py # samcli/commands/package/command.py # samcli/lib/package/artifact_exporter.py # samcli/lib/providers/sam_function_provider.py # samcli/lib/providers/sam_stack_provider.py # samcli/lib/utils/git_repo.py # samcli/lib/utils/hash.py # tests/integration/deploy/test_deploy_command.py # tests/testing_utils.py # tests/unit/commands/buildcmd/test_build_context.py # tests/unit/commands/deploy/test_deploy_context.py # tests/unit/commands/deploy/test_guided_context.py # tests/unit/commands/init/test_cli.py # tests/unit/commands/init/test_templates.py # tests/unit/commands/local/cli_common/test_invoke_context.py # tests/unit/commands/local/invoke/test_cli.py # tests/unit/commands/local/lib/test_sam_function_provider.py # tests/unit/commands/local/start_api/test_cli.py # tests/unit/commands/local/start_lambda/test_cli.py # tests/unit/commands/samconfig/test_samconfig.py # tests/unit/lib/build_module/test_build_graph.py # tests/unit/lib/utils/test_git_repo.py # tests/unit/local/lambdafn/test_runtime.py

…k-support-dev-merged-to-develop

hawflau · 2021-08-06T15:32:17Z

samcli/commands/deploy/guided_context.py

        """
-        default_stack_name = self.stack_name
-        default_region = self.region or get_session().get_config_variable("region") or "us-east-1"
+        default_stack_name = self.stack_name or "sam-app"


nit: We probably don't need to set the default value "sam-app" as I remember it is set somewhere before this step. But it shouldn't hurt to also have it here for now. My thought is that the default stack name is specific to which IaC platform is being used, so it should be set by the specific IaC plugin.

wchengru

LGTM.
I noticed a couple of commits are using codeuri and layers. I believe that the codeur in CDK format has no problem there after checking the changes, but want to give a heads up to avoid any potential regression.

hawflau · 2021-08-06T16:14:02Z

tests/testing_utils.py

        raise


+def run_command_with_inputs(command_list: List[str], inputs: List[str], timeout=TIMEOUT) -> CommandResult:


should the arguments here match the full argument list of run_command_with_input? (missing cwd)

aws#3030) * chore: removed unused code which was using pre-defined managed policy list and used in a sam translator wrapper, but the code path is not used. * make black

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>

hawflau

LGTM!

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* Add ECR credentials for windows test * Remove the dockerhub env vars

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* Add ECR credentials for windows test * Remove the dockerhub env vars * install aws cli in the windows test jobs

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

…pport-dev-merged-to-develop

…ons_Images test requirement (aws#3172) * chore: Update dateparser to 1.0 * Move public ECR limited test cases to Canary tests

* Python39 support for samcli (aws#354) * Python39 support for samcli * Updated reproducible-linux.txt and lambda_build_container.py for test purpose * Revert files after testing * updated integ test * updated appveyor * updated to appveyor * Update python3.9 appveyor config * update windows python3.9 executable path * update appveyor * fix lint and windows python appveyor script * bump version of lambda-builder to 1.6.0 Co-authored-by: jonife <79116465+jonife@users.noreply.github.com>

…pport-dev-merged-to-develop # Conflicts: # samcli/__init__.py # samcli/commands/build/command.py # tests/integration/init/schemas/test_init_with_schemas_command.py

…f the limitation of ecr

aahung and others added 30 commits April 14, 2021 16:59

chore: Use BUILD_TAG and JENKINS_URL to identify Jenkins env (aws#2805)

5f87fb2

* chore: Use BUILD_TAG instead of JENKINS_URL to identify Jenkins env * Keep JENKINS_URL

fix: Java Gradle 7 Build Test Data Issue (aws#2816)

4ab1fe3

* Updated Deprecated compile to implementation * Updated Tabs to Spaces * Updated for Kotlin * Updated More Tabs to Spaces

Request for Comments: Auto Create ECR Repos in Guided Deploy (aws#2675)

58a9427

* Added Auto Create ECR Design Doc * Updated Format * Addressed feedback

feat: add option --container-host and --container-host-interface to s…

3868987

…am local commands (aws#2806)

chore: bump version to 1.23.0 (aws#2824)

23aa4c9

Co-authored-by: Xia Zhao <xazhao@amazon.com>

refactor: Extract git-clone functionality out of InitTemplates class (a…

1e51f62

…ws#2821) * [Refactor] extract git-clone functionality out of InitTemplates class to its own class * apply review comments * typo * apply review comments

chore: add command line options to pyinstaller build script (aws#2829)

962ba9d

* chore: add command line options to pyinstaller build script * Update quotes * fix the dist folder name * update logs * trigger appveyor build

ignoring temp dirs used by dotnet (aws#2839)

5cc7680

Co-authored-by: Slava Senchenko <sencslav@amazon.com>

Point numpy version to <1.20.3 (aws#2868)

283e546

* Point numpy version to <1.19 to avoid PEP 317 failure * Update integ test python requirements which contain numpy * Fixing to numpy 1.20.2 * Revert "Fixing to numpy 1.20.2" This reverts commit a03f4d7. * Fixing numpy version to <1.20.3

chore: Overhaul the development guide (aws#2827)

9e03633

Validate default template.json (aws#2855)

f82da03

Issue: aws#2355 Added integration tests for `validate` command Co-authored-by: Slava Senchenko <sencslav@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>

fix: package/deploy failure when Location/TemplateURL is virtual host…

ade6e71

… S3 URL (aws#2785)

feat: Supports uncompression local layer zips in sam local (aws#2877)

81635be

fix: Ignore .aws-sam in sam build cache checksum (aws#2881)

0dfee7a

* feat: Allow dir_checksum() to accept a ignore_list * feat: Ignore .aws-sam when calculate cache md5

fix: Fix crash when nested CFN stack has dict TemplateURL (unresolved…

4e1a979

… intrinsics) (aws#2879) * fix: Fix crash when nested CFN stack has dict TemplateURL

Don't use layer.name in LayerBuildDefinition.__str__ (aws#2873)

199ded1

Watchdog error (aws#2902)

cc861a6

* chore: updating version of watchdog. Co-authored-by: Tarun Mall <tarun@amazon.noreply.github.com>

chore: Update aws_lambda_builders to 1.4.0 (aws#2903)

f9460f4

* chore: Update aws_lambda_builders to 1.4.0 * Update integration tests for new maven behavior * Add integ test for PEP 600 tags

chore: Adds missing unit tests for LayerBuildDefinition in build_graph (

321caf5

aws#2883) * Adds missing unit tests for LayerBuildDefinition in build_graph * fix black formatting

fix: Build graph tests using assertTrue instead of assertEqual + adde…

33d6c3b

…d assertions (aws#2909)

samconfig debug level logging fixed; documentation updated (aws#2891)

2a13a69

* samconfig debug level logging fixed; documentation updated * integration tests fix * help text improved Co-authored-by: Slava Senchenko <sencslav@amazon.com>

chore: update to aws-sam-translator 1.36.0 (aws#2917)

1e91773

Revert "samconfig debug level logging fixed; documentation updated (a…

5fecac5

…ws#2891)" (aws#2918) This reverts commit 2a13a69.

chore: bump version to 1.24.0 (aws#2919)

e5fc352

fix: Windows default validate template integration test (aws#2924)

72c0d5a

wchengru and others added 7 commits August 5, 2021 17:33

chore: upgrade pylint to 2.9.0 (aws#3119)

8ed8610

* chore: fix pylint failures in python3.9 * chore: fix pylint failures in python3.9 * chore: bump pylint version to 2.9.0 * fix typo * Add disabling reasons on new rules

fix: integration test case related to recent fix on ruby (aws#3124)

880c0b7

fix: add dockerhub default login server, improve logs to check docker…

afb0af1

… pull limitation (aws#3137)

fix: add sample payload for 'sam local generate-event stepfunctions e…

604c13a

…rror' (aws#3043) * add sample payload for 'sam local generate-event stepfunctions error' * add better default for error

fix conflicts

f25a63b

Merge remote-tracking branch 'aws-sam-cli-public/cdk-support' into cd…

e5df7df

…k-support-dev-merged-to-develop

moelasmar added the pr/internal label Aug 6, 2021

hawflau reviewed Aug 6, 2021

View reviewed changes

wchengru approved these changes Aug 6, 2021

View reviewed changes

hawflau reviewed Aug 6, 2021

View reviewed changes

mndeveci and others added 3 commits August 9, 2021 08:54

chore: removed unused code which was using pre-defined managed policy… (

0be8aa3

aws#3030) * chore: removed unused code which was using pre-defined managed policy list and used in a sam translator wrapper, but the code path is not used. * make black

feat(public-ecr): Download Emulation images (aws#3152)

af08766

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>

resolve PR comments

90dec81

moelasmar requested a review from hawflau August 11, 2021 06:33

hawflau approved these changes Aug 11, 2021

View reviewed changes

jfuss and others added 6 commits August 11, 2021 11:52

fix(integ): Use images that are in public ecr (aws#3162)

7f5de6b

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

Add ECR credentials for windows test (aws#3160)

a77d9e0

* Add ECR credentials for windows test * Remove the dockerhub env vars

fix(integ): Fix Invalid image tag errors (aws#3163)

16b8b4f

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

Install aws cli in the windows test jobs (aws#3164)

ce16584

* Add ECR credentials for windows test * Remove the dockerhub env vars * install aws cli in the windows test jobs

fix(integ): Add missing image to have deploy integ tests work (aws#3165)

8f4571d

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

Merge remote-tracking branch 'aws-sam-cli-public/develop' into cdk-su…

14ca227

…pport-dev-merged-to-develop

moelasmar force-pushed the cdk-support-dev-merged-to-develop branch from 1e9b60e to 14ca227 Compare August 13, 2021 07:27

wchengru and others added 6 commits August 16, 2021 09:25

chore: Update dateparser to 1.0, update TestBuildCommand_PythonFuncti…

0b05214

…ons_Images test requirement (aws#3172) * chore: Update dateparser to 1.0 * Move public ECR limited test cases to Canary tests

chore: bump SAM CLI version to 1.28.0 (aws#3174)

6e6aed6

Merge remote-tracking branch 'aws-sam-cli-public/develop' into cdk-su…

be72f56

…pport-dev-merged-to-develop # Conflicts: # samcli/__init__.py # samcli/commands/build/command.py # tests/integration/init/schemas/test_init_with_schemas_command.py

skip CDK build integration test cases to run during make-pr because o…

6848e28

…f the limitation of ecr

run black

7974332

moelasmar merged commit 673c3e2 into aws:cdk-support-dev Aug 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cdk-support-dev branch merged to develop branch#3146

cdk-support-dev branch merged to develop branch#3146
moelasmar merged 165 commits intoaws:cdk-support-devfrom
moelasmar:cdk-support-dev-merged-to-develop

moelasmar commented Aug 6, 2021

Uh oh!

hawflau Aug 6, 2021

Uh oh!

wchengru left a comment •

edited

Loading

Uh oh!

hawflau Aug 6, 2021

Uh oh!

hawflau left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		raise


		def run_command_with_inputs(command_list: List[str], inputs: List[str], timeout=TIMEOUT) -> CommandResult:

Conversation

moelasmar commented Aug 6, 2021

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Checklist

Uh oh!

hawflau Aug 6, 2021

Choose a reason for hiding this comment

Uh oh!

wchengru left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hawflau Aug 6, 2021

Choose a reason for hiding this comment

Uh oh!

hawflau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

wchengru left a comment •

edited

Loading