Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse error response body correctly #578

Closed

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Dec 24, 2019

This change corresponds to smithy-lang/smithy-typescript#66

This PR also update RDS-Data client to newest generated version. I have tested the client locally. This PR will unblock generating all JSON protocol clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AllanZhengYP and others added 30 commits September 19, 2019 14:52
* chore: add http request type guard for middlewares

header default middleware
expect continue middleare

* chore: add http request type guard for apply body checksum middlewares

* chore: only build and test demo smithy client

* feat: add isInstance to httpResponse

* chore: update rds data model

* chore: update to ts3.7; update rds model#3

* chore: update tsconfig to genenerte types only once

* chore: update gitignore

* chore: parse body with streamCollector

* chore: add error deserialization

* chore: stub Field union

* fix: fix middleware-header-default test

* fix: fix retry-middleware unit test
* feat: remove 'apply' entry from configuration definition

'apply' was used to adjust middleware stack and resolved configuration.
It is not relative as we are moving to conposition configuration, and
middleware stack should not be altered by configurations.
Address: aws#94

* feat: complete PoC composable configuration

* feat: change config resolver to multiple client config components

* feat: rename stack finalize step to finalizeRequest

* feat: add use() to smithy client to inject middleware

* fix: rename resolvedruntime configuration

* fix: remove exported reviouslyResolved interface

* feat: add metadatabearer to shapes

* feat: parse derializing utils as parameters

* use config interface as middleware parameter
* use smithy command as super class of all commands so we can support use() in commands

* feat: parse serialize(deserialize) util functions from client config

* Serializers/Deserializers should take utils functions from client config
first, if not available then fallback to generated dependencies. This
allows configuring the runtime dependencies manually from client config when
runtime-specific bundlers' decision is not accountable

* feat: add metadata deserializer

* docs: add documentation for config properties

* feat: add defaultUserAgen config

* feat: move some config components to middleware folder

* signing middleware
* retry middleware; Also update retry config interface by introducing RetryStrategy class

* feat: add input type proxy for better intellisense

* docs: add config doc block for retry config

* feat: add a user agent middleware to support custom useragent
…#389)

* feat: add RetryStrategy class and change retryMiddleware interface
* feat: remove generated SerDe runtime dependencies

Instead, use the runtime-specific utils specified in client config

* fix: change plugin interface to callback functions mutating the stack
* feat: support pluggable runtime config

* export runtimeConfig.runtime.ts to manually set the client to be compatible with specific runtime
* get rid of rollup, instead using browser property to swap runtime config
* add endpoint to the serializer utilities and insert it when building a request

* chore: set prettier-vscode as default formatter
* fix: remove duplicated declaration of endpoints

* fix: rename serializerUtils to serializerContext
* feat: combine serde types, cleanup unused imports

* feat: update model location

* feat: change Injectable to Pluggable
* feat: remove rest-json protocol class

* feat: rename handler to RequestHandler; Consolidate types
Chase Coalwell and others added 22 commits December 12, 2019 12:07
* feat: add predictEndpointMiddleware

* feat: remove modeled-endpoint-middleware

* feat: apply PredictEndpoint plugin
* fix: resolve region
feat: name package

feat: migrate and apply middleware

feat: remove $ input options

feat: remove preformedBucket option
* fix: add BucketEndpoint config plugin

* fix: package exports
…ddleware (aws#574)

* fix: use host name from request instead of endpont provider

* fix: assure bucketEndpointMw applies before hostHeaderMw
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Dec 24, 2019
@lock
Copy link

lock bot commented Feb 13, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants