-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newly added GitOps e2e test name to include "Flux" #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danbudris, jiayiwang7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override eks-anywhere-attribution-files-presubmit |
@danbudris: Overrode contexts on behalf of danbudris: eks-anywhere-attribution-files-presubmit, eks-anywhere-e2e-presubmit, eks-anywhere-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Update kubectl ValidateWorkerNodes arg to pass in kubeconfig (#1149) * Refactor GitOps e2e tests (#1176) * Refactor GitOps e2e test to pass in testOpts, add tests for workload cluster * Remove unused arg * Rename upgradeGitops methods * Remove unnecessary method * Generate GitOpsConfig name every time when running e2e flux test * Only generate lowercase alphanumeric string for K8s object names * Update newly added GitOps e2e test name to include "Flux" (#1193) * (#743) support passing multiple ips to cluster tests (#931) * Improvements for 'upgrades from latest release' e2e tests (#966) * Improvements for 'upgrades from latest release' e2e tests * Increas the timeout for kubeadm control plane ready in e2e tests * Increased timeout for cilium retrier * E2E tests for multiple worker node groups (#1194) Expands current e2e testing framework to support multiple worker node groups. It allows to add/remove/update worker node groups to the initial spec and during upgrades. Adds one simple vSphere tests that starts with two worker node groups. During the upgrade, it scales down one of them to 1 replica, it deletes the other one and creates a new one. * Update e2e test flow so cluster ip pool is not required (#1213) Co-authored-by: Joey Wang <jiayiwang7@yahoo.com> Co-authored-by: Greg Westerfield, Jr <gwesterf@amazon.com> Co-authored-by: Guillermo Gaston <gaslor@amazon.com> Co-authored-by: Greg Westerfield, Jr <gwesterfieldjr@gmail.com>
Issue #, if available:
The Flux e2e test envs are only set up when the test name includes "Flux" in it (https://github.com/aws/eks-anywhere/blob/main/internal/test/e2e/flux.go#L12).
Description of changes:
Change the newly added GitOps test name to include "Flux" so that the envs can be properly set. Also to keep it consistent with the existing tests. Later we can change all flux tests name to "GitOps" which makes more sense.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.