Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e test flow so cluster ip pool is not required #1213

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

gwesterfieldjr
Copy link
Contributor

no issue

Update e2e test flow so cluster ip pool is not required

Ran local e2e tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Feb 14, 2022
@eks-distro-bot
Copy link
Collaborator

Hi @gwesterfieldjr. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gwesterfieldjr
Copy link
Contributor Author

/ok-to-test

@eks-distro-bot
Copy link
Collaborator

@gwesterfieldjr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vivek-koppuru
Copy link
Member

/ok-to-test

test/e2e/README.md Show resolved Hide resolved
test/framework/vsphere.go Show resolved Hide resolved
@gwesterfieldjr gwesterfieldjr force-pushed the update-local-e2e-test-flow branch from 0ec964c to 5bd85b7 Compare February 14, 2022 22:57
test/framework/vsphere.go Outdated Show resolved Hide resolved
test/framework/vsphere.go Show resolved Hide resolved
@gwesterfieldjr gwesterfieldjr force-pushed the update-local-e2e-test-flow branch from 5bd85b7 to 922f66c Compare February 15, 2022 16:11
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston, gwesterfieldjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit e50f315 into aws:main Feb 15, 2022
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Feb 23, 2022
eks-distro-bot pushed a commit that referenced this pull request Feb 23, 2022
* Update kubectl ValidateWorkerNodes arg to pass in kubeconfig (#1149)

* Refactor GitOps e2e tests (#1176)

* Refactor GitOps e2e test to pass in testOpts, add tests for workload cluster

* Remove unused arg

* Rename upgradeGitops methods

* Remove unnecessary method

* Generate GitOpsConfig name every time when running e2e flux test

* Only generate lowercase alphanumeric string for K8s object names

* Update newly added GitOps e2e test name to include "Flux" (#1193)

* (#743) support passing multiple ips to cluster tests (#931)

* Improvements for 'upgrades from latest release' e2e tests (#966)

* Improvements for 'upgrades from latest release' e2e tests

* Increas the timeout for kubeadm control plane ready in e2e tests

* Increased timeout for cilium retrier

* E2E tests for multiple worker node groups (#1194)

Expands current e2e testing framework to support multiple worker node
groups. It allows to add/remove/update worker node groups to the initial
spec and during upgrades.

Adds one simple vSphere tests that starts with two worker node groups.
During the upgrade, it scales down one of them to 1 replica, it deletes
the other one and creates a new one.

* Update e2e test flow so cluster ip pool is not required (#1213)

Co-authored-by: Joey Wang <jiayiwang7@yahoo.com>
Co-authored-by: Greg Westerfield, Jr <gwesterf@amazon.com>
Co-authored-by: Guillermo Gaston <gaslor@amazon.com>
Co-authored-by: Greg Westerfield, Jr <gwesterfieldjr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants