Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#743) support passing multiple ips to cluster tests #931

Merged
merged 1 commit into from
Feb 11, 2022
Merged

(#743) support passing multiple ips to cluster tests #931

merged 1 commit into from
Feb 11, 2022

Conversation

gwesterfieldjr
Copy link
Contributor

@gwesterfieldjr gwesterfieldjr commented Jan 7, 2022 •
edited
Loading

#743

Update the test run to provide a pool of ips for cluster tests. Each test ec2 instance gets an ippool of ip addresses seeded via an env var reserved for the test clusters created by that e2e test session.

This PR is still in progress, but I needed to submit PR in order to get feedback from the CI to test e2e with ippool.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @gwesterfieldjr. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added needs-ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2022
@gwesterfieldjr
Copy link
Contributor Author

@abhinavmpandey08 @pokearu can you enable e2e test for me please?

@gwesterfieldjr
Copy link
Contributor Author

@abhinavmpandey08 @pokearu can you enable e2e test for me please?

Actually give me a minute. I'll ping on slack when I'm ready

@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 2 times, most recently from 66f7cc1 to eb0fac3 Compare January 7, 2022 18:39
@gwesterfieldjr gwesterfieldjr marked this pull request as draft January 7, 2022 18:50
@abhinavmpandey08
Copy link
Member

/ok-to-test

@gwesterfieldjr
Copy link
Contributor Author

gwesterfieldjr commented Jan 7, 2022 •
edited
Loading

/hold

Placing PR on hold as I would like to run e2e tests prior to merging which is not currently supported outside of running locally with proper vpshere info which I don't have at the moment.

cc: @abhinavmpandey08 @pokearu

@micahhausler micahhausler removed their request for review January 20, 2022 21:15
@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 3 times, most recently from 0f213e6 to e86cdbe Compare January 25, 2022 14:21
@gwesterfieldjr
Copy link
Contributor Author

/hold cancel

@gwesterfieldjr
Copy link
Contributor Author

/ok-to-test

@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 2 times, most recently from 4a3553d to 6075d76 Compare January 25, 2022 20:40
@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 4 times, most recently from 0b5c4b9 to a855776 Compare February 9, 2022 16:55
@gwesterfieldjr gwesterfieldjr marked this pull request as ready for review February 9, 2022 19:05
@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch from a855776 to 6618f7e Compare February 9, 2022 20:14
g-gaston
g-gaston reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 3 times, most recently from b4a1978 to 28da408 Compare February 10, 2022 14:25
@eks-distro-bot
Copy link
Collaborator

eks-distro-bot commented Feb 10, 2022 •
edited
Loading

@gwesterfieldjr: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
eks-anywhere-cluster-controller-tooling-presubmit a855776 link /test eks-anywhere-cluster-controller-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch from 28da408 to 30619ba Compare February 10, 2022 14:52
abhinavmpandey08
abhinavmpandey08 reviewed Feb 10, 2022
View reviewed changes
g-gaston
g-gaston approved these changes Feb 10, 2022
View reviewed changes
@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch 2 times, most recently from 37995bc to 80247ce Compare February 10, 2022 22:19
@gwesterfieldjr gwesterfieldjr force-pushed the 743-pass-multiple-ips-to-multicluster-e2e-test branch from 80247ce to 964d794 Compare February 11, 2022 14:54
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08, g-gaston, gwesterfieldjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavmpandey08,g-gaston]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavmpandey08
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit bc726dd into aws:main Feb 11, 2022
danbudris pushed a commit that referenced this pull request Feb 22, 2022
@gwesterfieldjr @danbudris
(#743) support passing multiple ips to cluster tests (#931)
7cff2ec
mitalipaygude pushed a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Feb 23, 2022
@gwesterfieldjr @mitalipaygude
(aws#743) support passing multiple ips to cluster tests (aws#931)
120a62a
eks-distro-bot pushed a commit that referenced this pull request Feb 23, 2022
@danbudris @jiayiwang7
@gwesterfieldjr @g-gaston
Backport: E2E test improvements (#1269)
45dec22 
* Update kubectl ValidateWorkerNodes arg to pass in kubeconfig (#1149)

* Refactor GitOps e2e tests (#1176)

* Refactor GitOps e2e test to pass in testOpts, add tests for workload cluster

* Remove unused arg

* Rename upgradeGitops methods

* Remove unnecessary method

* Generate GitOpsConfig name every time when running e2e flux test

* Only generate lowercase alphanumeric string for K8s object names

* Update newly added GitOps e2e test name to include "Flux" (#1193)

* (#743) support passing multiple ips to cluster tests (#931)

* Improvements for 'upgrades from latest release' e2e tests (#966)

* Improvements for 'upgrades from latest release' e2e tests

* Increas the timeout for kubeadm control plane ready in e2e tests

* Increased timeout for cilium retrier

* E2E tests for multiple worker node groups (#1194)

Expands current e2e testing framework to support multiple worker node
groups. It allows to add/remove/update worker node groups to the initial
spec and during upgrades.

Adds one simple vSphere tests that starts with two worker node groups.
During the upgrade, it scales down one of them to 1 replica, it deletes
the other one and creates a new one.

* Update e2e test flow so cluster ip pool is not required (#1213)

Co-authored-by: Joey Wang <jiayiwang7@yahoo.com>
Co-authored-by: Greg Westerfield, Jr <gwesterf@amazon.com>
Co-authored-by: Guillermo Gaston <gaslor@amazon.com>
Co-authored-by: Greg Westerfield, Jr <gwesterfieldjr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston g-gaston approved these changes

@abhinavmpandey08 abhinavmpandey08 abhinavmpandey08 approved these changes

@mdsgabriel mdsgabriel Awaiting requested review from mdsgabriel

Assignees

@abhinavmpandey08 abhinavmpandey08

Labels
approved lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwesterfieldjr @eks-distro-bot @abhinavmpandey08 @g-gaston