Enable secure connection in minio config for S3 integration #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
previously approved these changes
Sep 7, 2022
There was a problem hiding this comment.
@rrrkharse how to test this change? can we make this default in our tests?
what do you change on S3 side?
surajkota
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
This fix can be verified using this bucket policy
https://aws.amazon.com/premiumsupport/knowledge-center/s3-bucket-policy-for-config-rule/
Need to regenerate helm charts with this fix @rrrkharse @jsitu777
2 tasks
surajkota
pushed a commit
that referenced
this pull request
Sep 21, 2022
**Which issue is resolved by this Pull Request:** Resolves # **Description of your changes:** - Regenerate pipeline helm chart based on these two PR changes #335 #363 - update installation path dict for kubeflow-pipeline in vanilla and cognito **Testing:** - [ ] Unit tests pass - [x] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Adds #244 to main.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.