update kubeflow-pipeline and jupyter-web-app helm charts #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkota
requested changes
Sep 20, 2022
| @@ -0,0 +1,28 @@ | |||
| apiVersion: networking.istio.io/v1alpha3 | |||
There was a problem hiding this comment.
I think there is an issue in the srcipt, it pushed the jupyter web app related templates in kubeflow-pipelines in here
There was a problem hiding this comment.
it was a mis-conduct when I was pasting the path, removed the jupyter web app content from pipeline chart. Actually I need to regenerate the chart for pipeline s3 only
There was a problem hiding this comment.
done now @surajkota
There was a problem hiding this comment.
There was a problem hiding this comment.
@jsitu777 you need to regenerate chart for all kubeflow pipeline flavour to get in sync with
https://github.com/awslabs/kubeflow-manifests/pull/339/files#diff-402eb2df5dee333f2dc515c95eac04f19594757c7353a3feb15c8bf71aa89ff3R8-R10
surajkota
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.