Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow notebooks for 1.6 release #363

Merged
merged 6 commits into from
Sep 16, 2022

Conversation

mbaijal
Copy link
Contributor

@mbaijal mbaijal commented Sep 14, 2022

Description of your changes:

  1. Updated the TF version to 2.9.1
  2. Updated the Pytorch version to 1.12.0
  3. Added the kubeflow-katib package
  4. Update the tests as needed.

Testing:

  • Unit tests pass
  • e2e tests pass
  • Details about new tests (If this PR adds a new feature)
  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


# pytorch packages
# pytorch packages, latest version reinstalls Pytorch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some behavior change ? looks like version number is the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, that was more of a note to self, to not update that dependency to the latest version since it updated the pytorch binary as well.

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, lgtm otherwise

- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-tensorflow:2.6.3-cpu-py38-ubuntu20.04-v1.8
- public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-scipy:v1.6.0
- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-tensorflow:2.9.1-gpu-py39-cu112-ubuntu20.04-e3-v1.2
- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-tensorflow:2.9.1-cpu-py39-ubuntu20.04-e3-v1.2
- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-pytorch:1.11.0-gpu-py38-cu115-ubuntu20.04-e3-v1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I checked the Github releases pages for 1.12 but only one of the images and assumed it was not all released yet - DLC github releases and these docs don't seem to be in sync. Anyway, this helps us avoid the tricky tag update for Pytorch so let me make that change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tags have changed again, hence my confusion. I am working on this change.

- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-tensorflow:2.6.3-cpu-py38-ubuntu20.04-v1.8
- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-pytorch:1.11.0-gpu-py38-cu115-ubuntu20.04-e3-v1.1
- public.ecr.aws/c9e4w0g3/notebook-servers/jupyter-pytorch:1.11.0-cpu-py38-ubuntu20.04-e3-v1.1
- public.ecr.aws/j1r0q0g6/notebooks/notebook-servers/jupyter-scipy:v1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the jupyter location and feel free to merge it.

Everything else lgtm

@mbaijal mbaijal force-pushed the update-notebooks-1.6-rebased branch from 0d13e9a to e52a889 Compare September 16, 2022 01:05
@mbaijal mbaijal merged commit 43423cb into awslabs:main Sep 16, 2022
surajkota pushed a commit that referenced this pull request Sep 21, 2022
**Which issue is resolved by this Pull Request:**
Resolves #

**Description of your changes:**

- Regenerate pipeline helm chart based on these two PR changes
#335
#363
- update installation path dict for kubeflow-pipeline in vanilla and
cognito

**Testing:**
- [ ] Unit tests pass
- [x] e2e tests pass
- Details about new tests (If this PR adds a new feature)
- Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants