integration-test: Implement running on VMs #733
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mergify
bot
added
aya-log
There was a problem hiding this comment.
My biggest feedback about this PR at this point is that there's a lot of context in your brain about how these pieces fit together that aren't really apparent without unpacking the structure of the code.
In particular, a doc comment on the init process would be good. Also good would be a comment in xtask::run with a high-level overview of what's going on.
Thanks for making this all work on the mac! Very handy
There was a problem hiding this comment.
Done.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on @dave-tucker)
| @@ -72,6 +74,7 @@ lazy_static = { version = "1", default-features = false } | |||
| libc = { version = "0.2.105", default-features = false } | |||
| log = { version = "0.4", default-features = false } | |||
| netns-rs = { version = "0.1", default-features = false } | |||
| nix = { version = "0.26.2", default-features = false } | |||
There was a problem hiding this comment.
I for one am very pro nix and have 0 objections to using it in xtask.
ISTR in any we only used libc and I don't think we need to be as strict, but flagging it anyway.
Wait for at least one log and increase the wait time 10x.
There was a problem hiding this comment.
Yes, the comments please. Thank you.
Reviewable status: 0 of 11 files reviewed, 12 unresolved discussions (waiting on @dave-tucker and @tamird)
| line.with_context(|| format!("failed to read line from {qemu:?}"))?; | ||
| println!("{}", line); | ||
| if let Some(line) = line.strip_prefix("init: ") { | ||
| let previous = match line { |
Implements running integration tests on multiple VMs with arbitrary kernel images using `cargo xtask integration-test vm ...`. This changes our coverage from 6.2 to 6.1 and 6.4.
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 12 unresolved discussions (waiting on @dave-tucker)
a discussion (no related file):
Previously, dave-tucker (Dave Tucker) wrote…
I missed the parens when reviewing. I see them now.
Done.
a discussion (no related file):
Previously, dave-tucker (Dave Tucker) wrote…
If it's useful we keep it.
Done.
See individual commits.
This change is