Support multiple remote execution digest functions #16791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
from
8b62a48
to
cc9f8bb
Compare
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
from
cc9f8bb
to
ff4bb59
Compare
coeuvre
requested changes
Mar 14, 2023
| // Check execution digest function. The protocol only later added | ||
| // support for multiple digest functions for remote execution, so | ||
| // check both the singular and repeated field. | ||
| if (execCap.getDigestFunctionsList().isEmpty() && |
There was a problem hiding this comment.
It misses a case where execCap.getDigestFunctionsList().isEmpty() and execCap.getDigestFunction() == DigestFunction.Value.UNKNOWN, it should print the UNKNOWN function, instead of empty list.
There was a problem hiding this comment.
The question is, is this really what should be preferred? My interpretation is that digest_functions (plural) is what's authoritative now, with digest_function (singular) being a fallback. If both of them are unset, then I would assume it would make most sense to display an error message using the native format of digest_functions (plural), which is a list.
coeuvre
approved these changes
Mar 14, 2023
| // Check execution digest function. The protocol only later added | ||
| // support for multiple digest functions for remote execution, so | ||
| // check both the singular and repeated field. | ||
| if (execCap.getDigestFunctionsList().isEmpty() && |
coeuvre
added
the
awaiting-PR-merge
|
Hi @coeuvre, Should i import third-party changes first for this PR or share internal CL ? |
sgowroji
added
the
team-Remote-Exec
|
I will import the third-party changes via another CL. |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see #16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com>
|
Third Party changes are merged at d0cba55 |
sgowroji
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see bazelbuild#16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Closes bazelbuild#16791. PiperOrigin-RevId: 517084447 Change-Id: I72afce6c1fae9e624f9e7ed1936c744ae9c81280
keertk
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Support multiple remote execution digest functions The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see #16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com> (cherry picked from commit d0cba55) * Support multiple remote execution digest functions The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Closes #16791. PiperOrigin-RevId: 517084447 Change-Id: I72afce6c1fae9e624f9e7ed1936c744ae9c81280 (cherry picked from commit f8c8875) --------- Co-authored-by: Ed Schouten <eschouten@apple.com>
|
The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions:
bazelbuild/remote-apis#236
This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.