Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple digest functions #3467

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

tylerwilliams
Copy link
Member

@tylerwilliams tylerwilliams commented Feb 24, 2023

Support multiple digest functions in remote cache functionality.

N.B. This does not yet add support for multiple remote execution digest functions; that's dependent on bazelbuild/remote-apis#236 being merged and support being added to Bazel (bazelbuild/bazel#16791).

@tylerwilliams tylerwilliams changed the title two digests at the same time Add support for multiple digest functions Feb 24, 2023
Copy link
Contributor

@sluongng sluongng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most exciting changes are in server/remote_cache/digest/digest.go and server/remote_cache/byte_stream_server/byte_stream_server.go. Everything else seems to be simple API migration.

Few nits but overall LGTM.

server/remote_cache/digest/digest.go Outdated Show resolved Hide resolved
server/remote_cache/digest/digest.go Show resolved Hide resolved
server/remote_cache/digest/digest.go Outdated Show resolved Hide resolved
@tylerwilliams
Copy link
Member Author

PTAL

@tylerwilliams tylerwilliams merged commit 92baaf6 into master Feb 28, 2023
@tylerwilliams tylerwilliams deleted the two_digests_at_the_same_time branch February 28, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants