Support multiple remote execution digest functions #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
from
affd3a3
to
2046975
Compare
EdSchouten
added a commit
to EdSchouten/bazel
that referenced
this pull request
Nov 18, 2022
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.
|
Draft PR to let Bazel respect this: bazelbuild/bazel#16791 |
EdSchouten
added a commit
to EdSchouten/bazel
that referenced
this pull request
Nov 24, 2022
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.
|
As per the meeting yesterday, awaiting changes by @EdSchouten |
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
2 times, most recently
from
55d1e52
to
0c24e8e
Compare
|
Hey @sstriker, @EricBurnett, @bergsieker, As discussed during Tuesday's meeting, I have revised this PR, taking two things into consideration:
PTAL! |
mostynb
reviewed
Dec 15, 2022
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
2 times, most recently
from
cf9f2cc
to
44f747b
Compare
mostynb
reviewed
Dec 15, 2022
mostynb
reviewed
Dec 15, 2022
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
from
44f747b
to
61cf445
Compare
mostynb
approved these changes
Dec 26, 2022
|
Thanks for the review, @mostynb! |
This was referenced Dec 26, 2022
|
@sstriker @bergsieker @EricBurnett Hey there! Would you folks be interested in reviewing this PR, and PR #235? Thanks! |
EdSchouten
added a commit
to EdSchouten/bazel
that referenced
this pull request
Feb 24, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.
EricBurnett
approved these changes
Feb 27, 2023
|
@EdSchouten apologies for the long delay! @sstriker I see you added yourself; are you wanting to give input on this? Otherwise I'll give it a couple days and merge, as I think it's as discussed in the monthly. |
|
Another vote for merging this :) |
sstriker
approved these changes
Mar 14, 2023
My intent was to land this somewhere after last meeting. Then my 'round tuits went up in thin air. Apologies for the wait. |
Even though the cache can announce support for multiple digest functions, the remote execution system cannot. Let's address this inconsistency by adding a new repeated field that should in the (very) long term replace the singular field.
EdSchouten
force-pushed
the
eschouten/20221117-multiple-execution-digest-functions
branch
from
61cf445
to
5608a67
Compare
EdSchouten
added a commit
to EdSchouten/bazel
that referenced
this pull request
Mar 14, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account.
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 16, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see #16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com>
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 16, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Closes #16791. PiperOrigin-RevId: 517084447 Change-Id: I72afce6c1fae9e624f9e7ed1936c744ae9c81280
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see bazelbuild#16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Closes bazelbuild#16791. PiperOrigin-RevId: 517084447 Change-Id: I72afce6c1fae9e624f9e7ed1936c744ae9c81280
keertk
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Jul 25, 2023
* Support multiple remote execution digest functions The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Partial commit for third_party/*, see #16791. Signed-off-by: Sunil Gowroji <sgowroji@google.com> (cherry picked from commit d0cba55) * Support multiple remote execution digest functions The following PR on the remote-apis side adds support for remote execution services to announce support for multiple digest functions: bazelbuild/remote-apis#236 This makes migrating from one digest function to the other more graceful. This change extends Bazel's server capabilities checking code to take the new field in the execution capabilities into account. Closes #16791. PiperOrigin-RevId: 517084447 Change-Id: I72afce6c1fae9e624f9e7ed1936c744ae9c81280 (cherry picked from commit f8c8875) --------- Co-authored-by: Ed Schouten <eschouten@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the cache can announce support for multiple digest functions, the remote execution system cannot. Let's address this inconsistency by adding a new repeated field that should in the (very) long term replace the singular field.