Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty glob #4038

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Remove empty glob #4038

merged 1 commit into from
Nov 3, 2022

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Oct 21, 2022

This glob is not globbing anything.
This prevents flipping the flag incompatible_disallow_empty_glob https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1307#0183f814-adfb-484a-91e9-7608fe55a095

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #4040

Description of this change

This glob is not globbing anything.
This prevents flipping the flag incompatible_disallow_empty_glob
https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1307#0183f814-adfb-484a-91e9-7608fe55a095
@sgowroji sgowroji added topic: bazel Bazel integration (external repositories, aspects, flags, etc) awaiting-review Awaiting review from Bazel team on PRs labels Oct 26, 2022
@mai93 mai93 assigned mai93 and unassigned HaimingTian Nov 3, 2022
@mai93 mai93 merged commit 6948d38 into bazelbuild:master Nov 3, 2022
@jastice jastice removed the awaiting-review Awaiting review from Bazel team on PRs label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: bazel Bazel integration (external repositories, aspects, flags, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants