Remove empty glob #4038
Merged
Remove empty glob #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This glob is not globbing anything. This prevents flipping the flag incompatible_disallow_empty_glob https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1307#0183f814-adfb-484a-91e9-7608fe55a095
limdor
requested review from
mai93,
jastice,
tpasternak and
estebandlc
as code owners
56 tasks
sgowroji
added
topic: bazel
mai93
approved these changes
Nov 3, 2022
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Oct 7, 2024
This PR is to flip the default value of `incompatible_disallow_empty_glob`. This flag is tracked in #8195 and it is available since Bazel 0.29 from August 2019. Once this is merged, users still can allow empty globs without being explicit setting `--incompatible_disallow_empty_glob=false`. The motivation of the flip is bazel-contrib/SIG-rules-authors#37 and the fact of not keeping an incompatible flag for 4 years without flipping it. What needs to be done before flipping this: - [x] Merge protocolbuffers/upb#584 - [x] Update upb to a version that has the change in protocolbuffers/upb#584 - [x] Merge protocolbuffers/upb#745 - [x] Bring the changes from protocolbuffers/upb#745 to the 21.x branch - [x] Bring the changes from protocolbuffers/upb@e5f2601 to the 21.x branch (protocolbuffers/upb#781) - [x] Update upb to the latest commit of the 21.x branch (#16343) - [x] Merge #15374 - [x] Merge #15339 - [x] Merge #15330 - [x] Merge #16431 - [x] Merge #16468 - [x] Get green checks for this PR - [ ] Fix failures in downstream projects: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags - [ ] Fix empty globs from IntellIJ Plugin (https://github.com/bazelbuild/intellij) - [ ] Issue: bazelbuild/intellij#4040 - [ ] Android Studio Plugin - [ ] Android Studio Plugin Google - [ ] CLion Plugin - [ ] CLion Plugin Google - [ ] IntelliJ Plugin - [ ] IntelliJ Plugin Aspect - [ ] IntelliJ Plugin Aspect Google - [ ] IntelliJ Plugin Google - [ ] IntelliJ UE Plugin - [ ] IntelliJ UE Plugin Google - Opened PRs - [x] bazelbuild/intellij#4025 - [x] bazelbuild/intellij#4038 - [x] Fix empty globs from Bazel Bench (https://github.com/bazelbuild/bazel-bench) - [ ] bazelbuild/bazel-bench#174 - [x] bazelbuild/bazel-bench#149 - [x] Fix empty globs from Buildfarm (https://github.com/bazelbuild/bazel-buildfarm) - [x] Fix empty globs from Cargo - [x] ~~Fix empty globs from Cartographer (https://github.com/cartographer-project/cartographer)~~ (No longer maintained) - Issue: cartographer-project/cartographer#1908 - PR to enforce it cartographer-project/cartographer#1944 - [x] Fix empty globs from Cloud Robotics Core (https://github.com/googlecloudrobotics/core/) - [x] PR to prevent regresions googlecloudrobotics/core#279 - [ ] Fix empty globs from Envoy - [x] Fix empty globs from FlatBuffers - [x] Fix empty globs from Flogger - [ ] Fix empty globs from Gerrit (https://gerrit.googlesource.com/gerrit.git) - Issue: https://issues.gerritcodereview.com/issues/40011754 - [x] Fix empty globs from :bazel:Protobuf - [x] Fix empty globs from rules_android_ndk - [ ] Fix empty globs from rules_dotnet - [x] Fix empty globs from :bazel:rules_foreign_cc bazel-contrib/rules_foreign_cc#974 - [x] Fix empty globs from rules_go - [x] Fix empty globs from rules_haskell tweag/rules_haskell#1827 - [x] Fix empty globs from :bazel:rules_jvm_external - [x] Fix empty globs from rules_kotlin - [x] Fix empty globs from rules_nodejs - [x] Fix empty globs from :bazel:rules_python - [ ] Fix empty globs from rules_rust - [x] Fix empty globs from rules_swift - [x] Fix empty globs from rules_webtesting - [x] Fix empty globs from TensorFlow tensorflow/tensorflow#58155 - [x] tensorflow/tensorflow#58008 - [x] tensorflow/tensorflow#58154 - [x] Fix empty globs from upb RELNOTES[INC]: The flag `--incompatible_disallow_empty_glob` now defaults to true. Closes #15327. PiperOrigin-RevId: 683316885 Change-Id: Id34ffd32a9e979fada9207e475b826a508100ba5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This glob is not globbing anything.
This prevents flipping the flag incompatible_disallow_empty_glob https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1307#0183f814-adfb-484a-91e9-7608fe55a095
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #4040
Description of this change